fix(ivy): ensure eventListeners added outside angular context are not called #34514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: testing
| if (listener.name === getIdentifiableWrappedEventHandlerName()) { | ||
| const unwrappedListener = listener(Function); | ||
| return invokedListeners.indexOf(unwrappedListener) === -1 && | ||
| unwrappedListener.call(node, eventObj); |
There was a problem hiding this comment.
we use call(node,...) here, should we also use callback.call(node) in
angular/packages/core/src/debug/debug_node.ts
Line 430 in cb94a07
There was a problem hiding this comment.
From what I can see, the listeners here are retrieved from the LView and those would have been registered in the components/component templates. I think the this context in those functions would be the component class. I made the change because I think it's more correct but I don't think it ends up having downstream effects.
There was a problem hiding this comment.
Thanks, I will try to verify it.
mhevery
reviewed
Jan 14, 2020
atscott
changed the title
alxhub
reviewed
Jan 14, 2020
alxhub
approved these changes
Jan 14, 2020
atscott
force-pushed
the
eventlisteners
branch
3 times, most recently
from
f9f197e
to
587a94c
Compare
atscott
force-pushed
the
eventlisteners
branch
2 times, most recently
from
58d04a3
to
5f5b8aa
Compare
mhevery
suggested changes
Jan 21, 2020
atscott
force-pushed
the
eventlisteners
branch
from
5f5b8aa
to
74e8348
Compare
atscott
added
action: merge
atscott
force-pushed
the
eventlisteners
branch
from
74e8348
to
874f86e
Compare
atscott
force-pushed
the
eventlisteners
branch
2 times, most recently
from
c0a9d77
to
d0e14b8
Compare
AndrewKushnir
added
the
action: cleanup
|
@atscott FYI, it looks like size checks are failing in |
atscott
force-pushed
the
eventlisteners
branch
from
d0e14b8
to
dc9400b
Compare
atscott
removed
the
action: cleanup
… called... by DebugElement.triggerEventHandler. ZoneJS tracks the eventListeners on a node but we need to be able to differentiate between those added by Angular and those that were added outside the Angular context. This fix aligns with the behavior that was present in View Engine (not calling those listeners). If we decide later that we want to call those listeners, we still need a way to differentiate between those that we have wrapped in dom_renderer and those that were not (because they were added outside the Angular context).
atscott
force-pushed
the
eventlisteners
branch
from
dc9400b
to
9cdad74
Compare
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 22, 2020
… called... (#34514) by DebugElement.triggerEventHandler. ZoneJS tracks the eventListeners on a node but we need to be able to differentiate between those added by Angular and those that were added outside the Angular context. This fix aligns with the behavior that was present in View Engine (not calling those listeners). If we decide later that we want to call those listeners, we still need a way to differentiate between those that we have wrapped in dom_renderer and those that were not (because they were added outside the Angular context). PR Close #34514
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
… called... (angular#34514) by DebugElement.triggerEventHandler. ZoneJS tracks the eventListeners on a node but we need to be able to differentiate between those added by Angular and those that were added outside the Angular context. This fix aligns with the behavior that was present in View Engine (not calling those listeners). If we decide later that we want to call those listeners, we still need a way to differentiate between those that we have wrapped in dom_renderer and those that were not (because they were added outside the Angular context). PR Close angular#34514
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View Engine debug node does not call event listeners added outside the Angular context. This PR updates Ivy to mimic that behavior (not calling those listeners either when using
debugElement.triggerEventHandler)