New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): remove trailing whitespace for CurrencyPipe #34642
fix(common): remove trailing whitespace for CurrencyPipe #34642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix @troelslenda - the main fix and the tests look great. Could you remove the additional refactorings that were added (i.e. the addition and removal of parentheses, and the reformatting) since they are not relevant to this fix.
5812329
to
f051afd
Compare
Hi @petebacondarwin! Thank you for your quick response. I've cleaned up the PR with a |
Great! Thanks. |
Trimming any surrounding whitespace characters informatNumberToLocaleString if currency symbol issupressed. Closes angular#34641
f051afd
to
fb184e9
Compare
Hi @petebacondarwin |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Trimming any surrounding whitespace characters in
formatNumberToLocaleString if currency symbol is
supressed.
Closes #34641
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #34641
What is the new behavior?
The exessive whitespace is trimmed.
Does this PR introduce a breaking change?