perf(ngcc): only create tasks for non-processed formats (#35719) #35832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: merge
|
@caretaker, these changes have already been approved and landed on master (#35719). |
atscott
approved these changes
Mar 3, 2020
With this change we spawn workers lazily based on the amount of work that needs to be done. Before this change we spawned the maximum of workers possible. However, in some cases there are less tasks than the max number of workers which resulted in created unnecessary workers Reference: #35717 PR Close #35719
Change the behaviour in `analyzeEntryPoints` to only create tasks for non-processed formats. PR Close #35719
atscott
pushed a commit
that referenced
this pull request
Mar 3, 2020
With this change we spawn workers lazily based on the amount of work that needs to be done. Before this change we spawned the maximum of workers possible. However, in some cases there are less tasks than the max number of workers which resulted in created unnecessary workers Reference: #35717 PR Close #35719 PR Close #35832
atscott
pushed a commit
that referenced
this pull request
Mar 3, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch version of #35719