Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[global] white list web components selector for every module #36398

Closed
2 of 15 tasks
indraraj26 opened this issue Apr 2, 2020 · 6 comments
Closed
2 of 15 tasks

[global] white list web components selector for every module #36398

indraraj26 opened this issue Apr 2, 2020 · 6 comments
Assignees
Labels
area: core Issues related to the framework runtime core: directive matching cross-cutting: custom elements feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature
Milestone

Comments

@indraraj26
Copy link

🚀 Feature request

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Description

I am using this web components in my project https://www.npmjs.com/package/ionicons, Now i get this error
  1. If 'ion-icon' is an Angular component, then verify that it is part of this module.
    2. If 'ion-icon' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress
this message.

Now in every module i am adding this CUSTOM_ELEMENTS_SCHEMA

Describe the solution you'd like

Can we have global wise whitelist selector to act as an angular component.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@indraraj26
Copy link
Author

ionic-team/ionicons#816

@alan-agius4 alan-agius4 transferred this issue from angular/angular-cli Apr 2, 2020
@kara kara added the area: core Issues related to the framework runtime label Apr 2, 2020
@ngbot ngbot bot added this to the needsTriage milestone Apr 2, 2020
@pkozlowski-opensource
Copy link
Member

Related to #12045

@kara kara added the triage #1 label May 27, 2020
@jelbourn jelbourn added feature Issue that requests a new feature and removed type: use-case labels Oct 1, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Oct 1, 2020
@angular-robot angular-robot bot added the feature: votes required Feature request which is currently still in the voting phase label Jun 4, 2021
@angular-robot
Copy link
Contributor

angular-robot bot commented Jun 4, 2021

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link
Contributor

angular-robot bot commented Jun 25, 2021

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added the feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors label Jun 25, 2021
@JoostK JoostK self-assigned this May 25, 2022
@JoostK JoostK added this to Inbox in Feature Requests via automation May 25, 2022
@JoostK JoostK moved this from Inbox to Backlog in Feature Requests May 25, 2022
@JoostK
Copy link
Member

JoostK commented May 27, 2022

We do recognise this as a potential area for improvement; this will be considered in the design of #12045.

@JoostK JoostK closed this as completed May 27, 2022
Feature Requests automation moved this from Backlog to Closed May 27, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime core: directive matching cross-cutting: custom elements feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature
Projects
No open projects
Development

No branches or pull requests

6 participants