fix(compiler-cli): don't try to tag non-ts files as shims #36987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
force-pushed
the
ngtsc/ttc/fix-allowjs
branch
from
8ff5a40
to
0fb8a6d
Compare
alxhub
added
action: merge
Some projects include .js source files (via the TypeScript allowJs option). Previously, the compiler would attempt to tag these files for shims, which caused errors as the regex used to create shim filenames assumes a .ts file. This commit fixes the bug by filtering out non-ts files during tagging.
alxhub
force-pushed
the
ngtsc/ttc/fix-allowjs
branch
from
0fb8a6d
to
a34233e
Compare
petebacondarwin
approved these changes
May 7, 2020
JoostK
reviewed
May 7, 2020
| @@ -59,6 +59,7 @@ export class NgtscTestEnvironment { | |||
| "outDir": "built", | |||
| "rootDir": ".", | |||
| "baseUrl": ".", | |||
| "allowJs": true, | |||
There was a problem hiding this comment.
I would move this local to the test, as the test continues to pass without this flag (so anyone removing this in the future won't be able to see the effect of it, but it would render the test useless.)
JoostK
approved these changes
May 7, 2020
JoostK
added
the
action: cleanup
alxhub
removed
the
action: cleanup
3 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
) Some projects include .js source files (via the TypeScript allowJs option). Previously, the compiler would attempt to tag these files for shims, which caused errors as the regex used to create shim filenames assumes a .ts file. This commit fixes the bug by filtering out non-ts files during tagging. PR Close angular#36987
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects include .js source files (via the TypeScript allowJs option).
Previously, the compiler would attempt to tag these files for shims, which
caused errors as the regex used to create shim filenames assumes a .ts file.
This commit fixes the bug by filtering out non-ts files during tagging.