fix(common): add params and report progress to put

[ajitsinghkaler]

When response type is Json the put sigbnature did not have report progress and params key. This makes it difiicult to type check added them to the signature

Fixes #23600

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: #23600

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[jelbourn]

LGTM

Reviewed-for: public-api

[ajitsinghkaler]

Do we need a google3 presubmit on this??

[petebacondarwin]

This seems like a perfectly reasonable fix unless someone can explain why this particular overload did not have these options? It looks like a simple oversight to me.

There are some typos in the commit message. Can you change it to:

fix(common): add `params` and `reportProgress` options to `HttpClient.put()` overload

When the response type is JSON, the `put()` overload signature did not have `reportProgress`
and  `params` options. This makes it difficult to type-check this overload.

This commit adds them to the overload signature.

Fixes #23600

[ajitsinghkaler]

@petebacondarwin changed the message

[petebacondarwin]

Reviewed-for: public-api

[petebacondarwin]

Reviewed-for: public-api-approvers

[atscott]

Reviewed-for: public-api

[atscott]

Reviewed-for: fw-core

[AndrewKushnir]

Reviewed-for: public-api

[AndrewKushnir]

FYI, the remaining group that needs to give an LGTM is fw-http (@alxhub).

[ajitsinghkaler]

@AndrewKushnir is there a problem with the presubmit. Should I change something in this.

[AndrewKushnir]

Hi @ajitsinghkaler, I've started a new presubmit and will let you know how it goes. Meanwhile, could you please rebase this PR so we re-run CI for this change with the most up-to-date version of master branch? Thank you.

[ajitsinghkaler]

@AndrewKushnir rebased it.

[AndrewKushnir]

Hi @ajitsinghkaler, the presubmit went well. It looks like this PR has all approvals, so I'm adding the "merge" label. Thank you.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}