Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wtf): fix NgZone.run instrumentation #3788

Closed
wants to merge 1 commit into from
Closed

fix(wtf): fix NgZone.run instrumentation #3788

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Aug 22, 2015

The wrong branch was instrumented (when zone are disabled ie in CJS tests).

@mhevery what is the correct naming convention for scopes ?

  • _zone_run_scope: _scope suffix, snake cased
  • _zone_microtask: no suffix

What about using camel case as elsewhere ?

@vicb vicb added type: bug/fix comp: core action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 22, 2015
@mhevery mhevery added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 23, 2015
@mhevery
Copy link
Contributor

mhevery commented Aug 23, 2015

Not sure about the convention. Do you have a preference? Looks like I was not very consistent.

@mhevery mhevery assigned vicb and unassigned mhevery Aug 23, 2015
@vicb
Copy link
Contributor Author

vicb commented Aug 23, 2015

@mhevery What about _zoneRunScope to be consistent with other names ?
I can handle that as part of a new PR

@mary-poppins
Copy link

Merging PR #3788 on behalf of @vicb to branch presubmit-vicb-pr-3788.

@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Aug 23, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 23, 2015
@vicb vicb closed this in 5f0a0fd Aug 23, 2015
@vicb vicb deleted the 0821-wtf branch September 29, 2015 23:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@vicb vicb

Labels
cla: yes type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vicb @mhevery @mary-poppins @googlebot