Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): do not run build/pubbuild.dart twice #3831

Closed
wants to merge 1 commit into from

Conversation

marclaval
Copy link
Contributor

The build/pubbuild.dart should not run twice in a build.

Do not merge yet, the PR checks have been inverted for testing purpose.

@marclaval marclaval added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 25, 2015
@marclaval
Copy link
Contributor Author

Test successful, PTAL

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 25, 2015
@mary-poppins
Copy link

Merging PR #3831 on behalf of @mhevery to branch presubmit-mhevery-pr-3831.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 25, 2015
@mhevery mhevery added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Aug 25, 2015
@mary-poppins
Copy link

Merging PR #3831 on behalf of @mhevery to branch presubmit-mhevery-pr-3831.

@mary-poppins mary-poppins removed action: merge The PR is ready for merge by the caretaker labels Aug 25, 2015
@mary-poppins
Copy link

Merging PR #3831 on behalf of @mhevery to branch presubmit-mhevery-pr-3831.

@marclaval marclaval closed this in e72305e Aug 25, 2015
@marclaval marclaval deleted the pubbuild branch December 11, 2017 10:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants