New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zone.js): add missing types field in package.json #38585
Conversation
50328b7
to
90e88ed
Compare
99ac50b
to
8b77caa
Compare
8b77caa
to
c671dd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve' other comments before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment/suggestion.
4e837f8
to
9d3fa9f
Compare
Close angular#38584 In zone.js 0.11.1, the `types` field is missing in the `package.json`, the reason is in zone.js 0.11.0, the `files` field is used to specify the types, but it cause the npm package not contain any bundles issue, so zone.js 0.11.1 remove the `files` field, which cause the `type` definition gone. This PR concat the `zone.js.d.ts`, `zone.configurations.api.ts`, `zone.api.extensions.ts` types into a single `zone.d.ts` file.
9d3fa9f
to
470d555
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Close #38584
In zone.js 0.11.1, the
types
field is missing in thepackage.json
,the reason is in zone.js 0.11.0, the
files
field is used to specify thetypes, but it cause the npm package not contain any bundles issue, so zone.js
0.11.1 remove the
files
field, which cause thetype
definition gone.This PR concat the
zone.js.d.ts
,zone.configurations.api.ts
,zone.api.extensions.ts
types into a single
zone.js.d.ts
file.