Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add upcoming angular conferences #38874

Closed
wants to merge 2 commits into from
Closed

Conversation

mgechev
Copy link
Member

@mgechev mgechev commented Sep 16, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there will be ngPoland at the same time as EnterpriseNG.

@sonukapoor
Copy link
Contributor

@mgechev CI currently fails to detect PRs if they come from angular/angular instead of a fork, which is why the deploy_aio job is failing.

@mgechev
Copy link
Member Author

mgechev commented Sep 16, 2020

@sonukapoor thanks for the heads up.

@mgechev mgechev added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 16, 2020
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Sep 16, 2020
@ngbot
Copy link

ngbot bot commented Sep 16, 2020

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: deploy_aio" is failing
    pending missing required labels: target: *
    pending status "pullapprove" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 16, 2020
@AndrewKushnir
Copy link
Contributor

Hi @mgechev, it looks like there is a conflict with the master branch after merging 5b33798. Could you please update your PR and resolve conflicts? Thank you.

@mgechev
Copy link
Member Author

mgechev commented Sep 16, 2020

@AndrewKushnir done!

@AndrewKushnir
Copy link
Contributor

Thanks @mgechev 👍

@AndrewKushnir AndrewKushnir removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 16, 2020
aio/content/marketing/events.json Outdated Show resolved Hide resolved
@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Sep 17, 2020
Co-authored-by: George Kalpakas <kalpakas.g@gmail.com>
@mgechev mgechev added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 17, 2020
mhevery pushed a commit that referenced this pull request Sep 18, 2020
mhevery pushed a commit that referenced this pull request Sep 18, 2020
Co-authored-by: George Kalpakas <kalpakas.g@gmail.com>
PR Close #38874
@mhevery mhevery closed this in ef28e15 Sep 18, 2020
mhevery pushed a commit that referenced this pull request Sep 18, 2020
Co-authored-by: George Kalpakas <kalpakas.g@gmail.com>
PR Close #38874
@mgechev mgechev deleted the angular-conferences branch September 18, 2020 15:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants