Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs-infra): update docs examples to Angular v10 (and related changes) #38922

Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Sep 21, 2020

WIP

@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project comp: docs state: WIP target: patch This PR is targeted for the next patch release labels Sep 21, 2020
@ngbot ngbot bot modified the milestone: needsTriage Sep 21, 2020
@gkalpak gkalpak added this to IN PROGRESS in docs-infra Sep 21, 2020
@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from 8504322 to 8861dae Compare September 21, 2020 20:57
@mary-poppins
Copy link

You can preview 8861dae at https://pr38922-8861dae.ngbuilds.io/.

…les in `aio/tools/`

This commit updates the Markdown files inside the `aio/tools/` directory
to contain one sentence per line in order to be consistent with how
Markdown files are formatted in the rest of the repo.
@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch 2 times, most recently from 299bb66 to cf497e1 Compare September 23, 2020 11:18
@mary-poppins
Copy link

You can preview cf497e1 at https://pr38922-cf497e1.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from cf497e1 to 24416b7 Compare September 23, 2020 15:17
@mary-poppins
Copy link

You can preview 24416b7 at https://pr38922-24416b7.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from 24416b7 to 32d6381 Compare September 23, 2020 18:04
@mary-poppins
Copy link

You can preview 32d6381 at https://pr38922-32d6381.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from 32d6381 to 1c95007 Compare September 23, 2020 18:56
@mary-poppins
Copy link

You can preview 1c95007 at https://pr38922-1c95007.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from 1c95007 to 5b6623f Compare September 23, 2020 19:23
@mary-poppins
Copy link

You can preview 5b6623f at https://pr38922-5b6623f.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from 5b6623f to 9076f14 Compare September 23, 2020 19:45
@mary-poppins
Copy link

You can preview 9076f14 at https://pr38922-9076f14.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 49235aa at https://pr38922-49235aa.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from 49235aa to 240541c Compare September 23, 2020 20:44
@mary-poppins
Copy link

You can preview 240541c at https://pr38922-240541c.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from 240541c to 4a4a06e Compare September 23, 2020 21:07
@mary-poppins
Copy link

You can preview 4a4a06e at https://pr38922-4a4a06e.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch 2 times, most recently from 36a8287 to 4c04236 Compare September 24, 2020 09:42
@mary-poppins
Copy link

You can preview 4c04236 at https://pr38922-4c04236.ngbuilds.io/.

…es boilerplate

When updating the boilerplate for CLI-based docs examples, one needed to
install dependencies inside the
`aio/tools/examples/shared/boilerplate/cli/` directory, which resulted
in a `node_modules/` directory and a `yarn.lock` file. These were not
supposed to be part of the boilerplate, so they had to be manually
removed after the boilerplate was updated.

This commit simplifies the workflow by allowing boilerplate files to be
ignored (both by git and the `example-boilerplate.js` script) via a
`.gitignore` file. This way, it is no longer necessary to manually
remove the unneeded directories/files.
…ilerplate

Previously, when updating the dependency versions in
`aio/tools/examples/shared/package.json` (which contains all
dependencies used in docs examples projects), one had to manually go
through all boilerplate directories and update the `package.json` files
with the same versions.

This commit simplifies this task by automating it via a Node.js script.
@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from 4c04236 to aa17330 Compare September 24, 2020 17:38
@mary-poppins
Copy link

You can preview aa17330 at https://pr38922-aa17330.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from aa17330 to 7d6b038 Compare September 24, 2020 22:32
This commit updates the docs examples to Angular v10.1.3. In addition to
updating the dependencies versions, it also updates the project's
structure and config to more closely match what a new v10 CLI app would
look like. See, also, the [diff][1] between a basic v9.1.4 CLI app and a
v10.1.3 one.

[1]: https://github.com/cexbrayat/angular-cli-diff/compare/9.1.4..10.1.3
@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from 7d6b038 to 3104c3c Compare September 25, 2020 07:33
@mary-poppins
Copy link

You can preview 3104c3c at https://pr38922-3104c3c.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-aio-update-docs-examples branch from 3104c3c to 3a87103 Compare September 25, 2020 09:36
@mary-poppins
Copy link

You can preview 3a87103 at https://pr38922-3a87103.ngbuilds.io/.

@gkalpak gkalpak closed this Sep 25, 2020
@gkalpak
Copy link
Member Author

gkalpak commented Sep 25, 2020

Split out as #38992 and #38993.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: build & ci Related the build and CI infrastructure of the project cla: yes state: WIP target: patch This PR is targeted for the next patch release
Projects
docs-infra
IN PROGRESS
Development

Successfully merging this pull request may close these issues.

None yet

3 participants