Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transpiler: handle named parameters #38

Closed
vsavkin opened this issue Sep 30, 2014 · 2 comments · Fixed by #44
Closed

transpiler: handle named parameters #38

vsavkin opened this issue Sep 30, 2014 · 2 comments · Fixed by #44
Assignees

Comments

@vsavkin
Copy link
Contributor

vsavkin commented Sep 30, 2014

 it('should compile named params when the last argument is a map', function() {
    function f(a, {b, c}) {return a + b + c;}

    expect(f(1, {b: 2, c: 3})).toBe(6);
  });

  it('should compile to a map when keys are quoted', function() {
    function f(m) {return m["a"] + m["b"];}

    expect(f({"a": 1, "b": 2})).toBe(3);
  });
@vsavkin vsavkin self-assigned this Sep 30, 2014
@mhevery
Copy link
Contributor

mhevery commented Sep 30, 2014

This should also handle default values for the named parameters

function({a=1}) => a({a:1})

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants