Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zone.js latest version #39094

Closed
eun-choi opened this issue Oct 2, 2020 · 18 comments
Closed

zone.js latest version #39094

eun-choi opened this issue Oct 2, 2020 · 18 comments
Assignees
Labels
area: zones P2 The issue is important to a large percentage of users, with a workaround
Milestone

Comments

@eun-choi
Copy link

eun-choi commented Oct 2, 2020

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

I know that 0.11.2 version of zone.js has been released through the following commit : a6971ba89adc253bfa4260036ee4a1e0bd76159f

However, There is no version 0.11.2 on NPM site yet.
https://www.npmjs.com/package/zone.js

Is it intended?

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

@ngbot ngbot bot added this to the needsTriage milestone Oct 2, 2020
@JiaLiPassion
Copy link
Contributor

The new release will be available very soon, please wait for a little while.

@crfrolik
Copy link

crfrolik commented Oct 8, 2020

Is it possible to change the @angular/core peer dependency of zone.js so there is no warning when using zone.js 0.11.X?

@hfournier
Copy link

hfournier commented Oct 14, 2020

I just tried to update from 10.1.1 to 10.1.6 using:

ng update @angular/core

and got:

                  Package "@angular/core" has an incompatible peer dependency to "zone.js" (requires "~0.10.3", would install "0.11.1")
× Migration failed: Incompatible peer dependencies found.

so it's not just a warning now

@bboydflo
Copy link

I've got the same issue as @hfournier

@JiaLiPassion
Copy link
Contributor

zone.js 0.11.2 has been released, and about the peer denedency warning, it will be updated soon.

@muuvmuuv
Copy link

Is it save to always use latest zone.js with latest Angular?

@JiaLiPassion
Copy link
Contributor

@muuvmuuv , it is safe to use the latest version, if there is breaking changes that impact the existing apps, it will follow the same policy with other angular packages.

@AndrewKushnir
Copy link
Contributor

Closing this ticket based on the comments above (zone.js version that should resolve the problem is released). Please reopen if the problem still exists.

@hfournier
Copy link

hfournier commented Oct 30, 2020

I can confirm that I was able to update to the latest @angular/core 10.2.1, but when try:

ng update zone.js

I get:

Fetching dependency metadata from registry...
                  Package "@angular/core" has an incompatible peer dependency to "zone.js" (requires "~0.10.3", would install "0.11.2").
× Migration failed: Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.
Angular CLI: 10.2.0
Node: 14.7.0
OS: win32 x64

Angular: 10.2.1
... animations, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1002.0
@angular-devkit/build-angular   0.1002.0
@angular-devkit/core            10.2.0
@angular-devkit/schematics      10.2.0
@angular/cli                    10.2.0
@angular/google-maps            10.2.6
@schematics/angular             10.2.0
@schematics/update              0.1002.0
rxjs                            6.6.3
typescript                      4.0.5

@AndrewKushnir
Copy link
Contributor

Hi @hfournier, thanks for the feedback.
It looks like the problem still exists, so I'm re-opening this issue.

@AndrewKushnir AndrewKushnir reopened this Oct 30, 2020
@AndrewKushnir AndrewKushnir added the P2 The issue is important to a large percentage of users, with a workaround label Oct 30, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Oct 30, 2020
@napei
Copy link

napei commented Nov 12, 2020

This still seems to happen in v11 as the peer dependency requirements of @angular/core are not set to accept the latest version of zone

Package "@angular/core" has an incompatible peer dependency to "zone.js" (requires "~0.10.3", would install "0.11.3")

@Splaktar
Copy link
Member

I just raised this with the team to try and get some clarification and hopefully a resolution here.

@Splaktar
Copy link
Member

Splaktar commented Dec 10, 2020

✅ Fixed in c43267b which should be released in @angular/core@11.1.0.

@kbradl16
Copy link

kbradl16 commented Jan 6, 2021

@Splaktar doesnt look like this was ever published? When will 11.1.0 be released?

@Splaktar
Copy link
Member

Splaktar commented Jan 6, 2021

@kbradl16 not yet, there should be an 11.1.0-rc.0 release sometime next week.

@Splaktar
Copy link
Member

Splaktar commented Jan 6, 2021

@kbradl16 this is available in 11.1.0-next.1 and today's 11.1.0-next.4 preview release.

@JoostK
Copy link
Member

JoostK commented May 7, 2021

The peer dependency was updated in #39809, so closing as resolved.

@JoostK JoostK closed this as completed May 7, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: zones P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

No branches or pull requests

13 participants