fix(build): Use Angular's testability API to wait for end of e2e tests #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclaval
force-pushed
the
issue3829
branch
2 times, most recently
from
c230734
to
b060532
Compare
marclaval
added
the
action: review
| var result = _get.apply(this, arguments); | ||
| browser.driver.wait(protractor.until.elementLocated(By.js('var cs = document.body.children; var isLoading = false; for (var i = 0; i < cs.length; i++) {if (cs[i].textContent.indexOf("Loading...") > -1) isLoading = true; } return !isLoading ? document.body.children : null')), sleepInterval); | ||
| return result; | ||
| // Benchmarks never need to wait for Angular 2 to be ready |
There was a problem hiding this comment.
Why is this? Benchmarks also contain regular Ng2 applications...
tbosch
added
the
action: cleanup
|
@Mlaval ping? |
marclaval
force-pushed
the
issue3829
branch
3 times, most recently
from
b23e967
to
ec05ecf
Compare
marclaval
removed
the
action: cleanup
| @@ -11,7 +11,8 @@ describe('ng2 static tree benchmark', function() { | |||
| url: URL, | |||
| buttons: ['#ng2DestroyDom', '#ng2CreateDom'], | |||
| id: 'ng2.static.tree.create.viewcache', | |||
| params: [{name: 'viewcache', value: 'true'}] | |||
| params: [{name: 'viewcache', value: 'true'}], | |||
| waitForAngular2: true | |||
There was a problem hiding this comment.
Can we make this the default (waitForAngular2=true) and then not specify it in every benchmark configuration?
tbosch
added
pr_state: LGTM
action: cleanup
marclaval
force-pushed
the
issue3829
branch
from
ec05ecf
to
b724f36
Compare
marclaval
added
action: review
|
Merging PR #3911 on behalf of @tbosch to branch presubmit-tbosch-pr-3911. |
|
FYI - we'll be moving some of this logic in to Protractor in the next release. Leaving myself a note to make sure to modify what needs to be updated here. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3829
Some comments:
.get()from webdriver instead of the patched one from Protractor.TestabilityAPI is not available for web workers cases, so they are managed as if no waiting was needed