test(zone.js): add basic test for zone.js bundle size #39111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zone.js bundle size impacts the `polyfills` size very much, so in this PR, the basic test for legacy bundle `zone.umd.js` and evergreen bundle `zone.js`. The script checks the unzipped and gzipped version of the bundles.
gkalpak
requested changes
Oct 5, 2020
There was a problem hiding this comment.
Could we not use payload-size.sh, either directly (as we do in aio/scripts/payload.sh) or via bazel (as we do for integration tests as part of angular_integratrion_test)?
We already have multiple ways of measuring/tracking payload sizes. I'd be wary of introducing another one 😰
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zone.js bundle size impacts the
polyfillssize very much, so in this PR,the basic test for legacy bundle
zone.umd.jsand evergreen bundlezone.js.The script checks the unzipped and gzipped version of the bundles.