Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Ivy, pipes in projected content uses viewProviders from a host component where ViewEngine did not #39276

Open
EmaGht opened this issue Oct 14, 2020 · 2 comments
Assignees
Labels
area: core Issues related to the framework runtime core: di core: pipes P4 A relatively minor issue that is not relevant to core functions regression Indicates than the issue relates to something that worked in a previous version
Milestone

Comments

@EmaGht
Copy link

EmaGht commented Oct 14, 2020

Closely related to: #36146

馃悶 bug report

Affected Package

@angular/core

Is this a regression?

Yes.
Worked with VE.
Half worked after the bugfix that closed #36146.
Half is broken

Description

This time the problem happens when the pipe is used inside a template projected into the host component

馃敩 Minimal Reproduction

https://github.com/EmaGht/ivypipe

I would love to provide an ng-run version, and God knows i tried, but apparently any package i try to install >9.1.0 simply hangs/doesn't install/crash/makes me question WHY/etc...

馃實 Your Environment

Angular Version:

Angular CLI: 10.1.6
Node: 12.18.3
OS: win32 x64

Angular: 10.1.5
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.1001.6
@angular-devkit/build-angular 0.1001.6
@angular-devkit/core 10.1.6
@angular-devkit/schematics 10.1.6
@angular/cli 10.1.6
@schematics/angular 10.1.6
@schematics/update 0.1001.6
rxjs 6.6.3
typescript 4.0.3

Anything else relevant?
Every time i try to make this behavior work in my application i have to manually edit 200+ components.

I did it once at the beginning, thinking Ivy would be backward compatible with VE, jokes on me
I did it once again today, because i trusted the fact the issue had been solved, jokes on me
they say the third is the good one, I'm counting on that!

@atscott atscott added the area: core Issues related to the framework runtime label Oct 14, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 14, 2020
@jelbourn jelbourn added the P4 A relatively minor issue that is not relevant to core functions label Oct 19, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Oct 19, 2020
@jelbourn jelbourn added regression Indicates than the issue relates to something that worked in a previous version engine: ivy labels Oct 19, 2020
@FortinFred
Copy link

I have a similar issue and it was working for me except once I got on the CI server.

So I rebuilt my local dev environment and now it's broken. I haven't identified what was different on my local dev but this is something that used to work and now is broken.

I'm using version 10.

@EmaGht
Copy link
Author

EmaGht commented Jan 27, 2022

Hello guys! Any update regarding this regression?

Sorry for bothering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues related to the framework runtime core: di core: pipes P4 A relatively minor issue that is not relevant to core functions regression Indicates than the issue relates to something that worked in a previous version
Projects
None yet
Development

No branches or pull requests

6 participants