Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare bones change detection #39

Closed
mhevery opened this issue Sep 30, 2014 · 4 comments · Fixed by #62
Closed

Bare bones change detection #39

mhevery opened this issue Sep 30, 2014 · 4 comments · Fixed by #62
Assignees

Comments

@mhevery
Copy link
Contributor

mhevery commented Sep 30, 2014

We would like to implement bare bones change detection so that we can unblock ourselves for other parts of the system and work on them in parallel.

https://github.com/mhevery/angular/blob/master/modules/change_detection/src/watch_group.js
https://github.com/mhevery/angular/blob/master/modules/change_detection/src/record.js

I would love to get a very simple change detection going which can only watch simple properties such as foo or bar ie no (foo.bar or foo().bar or anything of that sort)

We should be able to implement this without the need for parser.

class Person {
  var age;
}

var person = new Person();
var pwg = new ProtoWatchGroup();
pwg.watch('age');
var wg = pwg.instantiate();
wg.setContext(person);
var cd = new ChangeDetection(wg);
cd.detectChanges();

Make this test pass:

it('should do simple watching', function() {

@mhevery mhevery added the ready label Sep 30, 2014
@mhevery mhevery added this to the October milestone Sep 30, 2014
@mhevery mhevery assigned davidjnelson and vicb and unassigned davidjnelson Sep 30, 2014
@vicb
Copy link
Contributor

vicb commented Oct 1, 2014

@mhevery could we discuss that ? how does this relates to #31 ?

@mhevery
Copy link
Contributor Author

mhevery commented Oct 1, 2014

Closed #31 as duplicate. Yes let's chat, tomorrow after Mock interview?

@mhevery
Copy link
Contributor Author

mhevery commented Oct 2, 2014

@vicb vicb added in progress and removed ready labels Oct 3, 2014
vicb added a commit to vicb/angular that referenced this issue Oct 6, 2014
vicb added a commit to vicb/angular that referenced this issue Oct 7, 2014
vicb added a commit to vicb/angular that referenced this issue Oct 7, 2014
vicb added a commit to vicb/angular that referenced this issue Oct 7, 2014
vicb added a commit to vicb/angular that referenced this issue Oct 7, 2014
vicb added a commit to vicb/angular that referenced this issue Oct 7, 2014
vicb added a commit to vicb/angular that referenced this issue Oct 7, 2014
vicb added a commit to vicb/angular that referenced this issue Oct 8, 2014
@vicb vicb closed this as completed in #62 Oct 8, 2014
@vicb vicb removed the in progress label Oct 8, 2014
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants