Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perf): change detection profiler #4000

Closed
wants to merge 1 commit into from
Closed

feat(perf): change detection profiler #4000

wants to merge 1 commit into from

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Sep 4, 2015

Fixes #3877

@yjbanov yjbanov added comp: core/change_detection area: performance Issues related to performance action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 4, 2015
vsavkin
vsavkin reviewed Sep 4, 2015
View reviewed changes
modules/angular2/test/toolz/spies.dart
@@ -0,0 +1,21 @@
import 'package:angular2/test_lib.dart' show SpyObject;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why toolz and not tools?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something in our build pipeline that doesn't like directories named tools. It causes Karma to look for _spec files outside modules. I couldn't figure it out, so for now making it toolz.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Igor helped me fix this (some weird special case in Karma config)

@vsavkin vsavkin assigned yjbanov and unassigned vsavkin Sep 4, 2015
@yjbanov yjbanov removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 4, 2015
@yjbanov yjbanov force-pushed the cd-profiler branch 5 times, most recently from a89cf7a to f55c551 Compare September 8, 2015 20:36
@mary-poppins
Copy link

Merging PR #4000 on behalf of @yjbanov to branch presubmit-yjbanov-pr-4000.

@yjbanov yjbanov added the action: merge The PR is ready for merge by the caretaker label Sep 9, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 9, 2015
@yjbanov yjbanov closed this in 8dd6c46 Sep 9, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@yjbanov yjbanov

Labels
area: performance Issues related to performance cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement programmatic change detection profiler
4 participants
@yjbanov @mary-poppins @vsavkin @googlebot