Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs state to update as follows, but does not mention what to do #40280

Closed
ShubhankarKG opened this issue Dec 30, 2020 · 7 comments
Closed

Docs state to update as follows, but does not mention what to do #40280

ShubhankarKG opened this issue Dec 30, 2020 · 7 comments
Milestone

Comments

@ShubhankarKG
Copy link

馃摎 Docs or angular.io bug report

Description

On the page Adding Navigation, there is a section where we need to update the products by adding a productId. The statement reads, and I quote:

Update the *ngFor directive to read as follows. This statement instructs Angular to iterate over the items in the products array and assigns each index in the array to the productId variable when iterating over the list.

But there is nothing below that actually does this. Was this intentional? If it was, maybe rephrase the sentence to mean that you need to do it.

馃敩 Minimal Reproduction

What's the affected URL?**

https://angular.io/start/start-routing

Expected vs Actual Behavior**

I expected a code stub that succeded this statement, indicating that this is what you need to do, as a newbie 馃槄 .

馃摲Screenshot

Screenshot from 2020-12-30 19-15-01

Anything else relevant?

If this is an easy fix, maybe I myself can try this out. Thanks.

@ngbot ngbot bot added this to the needsTriage milestone Dec 30, 2020
@sonukapoor
Copy link
Contributor

@ShubhankarKG The steps 3-5 are all referring to the code block that you see after step 5.

@ShubhankarKG
Copy link
Author

Oh, thanks. Then the statement :

and assigns each index in the array to the productId variable when iterating over the list.

is misleading, don't you think so? Since the previous tutorial did not have the id attribute at all.

@sonukapoor
Copy link
Contributor

Yes. That is misleading, as there is no usage of the productId in the code section.

@ShubhankarKG
Copy link
Author

Thanks! Then I guess that we can add that to the starter code itself. That'll eliminate this inconsistency I think.

If it's not too much of a bother, could you let me know where this code resides so that I can make a quick fix?

Thanks!

@sonukapoor
Copy link
Contributor

@gkalpak
Copy link
Member

gkalpak commented Jan 6, 2021

Thx for reporting this, @ShubhankarKG!
I am going to close this as a duplicate of #40189. (It will be fixed by #40197.)

@gkalpak gkalpak closed this as completed Jan 6, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants