fix(router): Remove usage of Object.values to avoid the need for a …
#40370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…polyfill `Object.values` is not supported in IE11 without a polyfill. The quickest, most straightfoward fix for this is to simply use `Object.keys` instead. We may want to consider including the polyfill in the CLI in the future or just wait until IE11 support is dropped before using `Object.values`.
atscott
added
area: router
target: patch
kyliau
approved these changes
Jan 9, 2021
|
Should close #40372 |
atscott
added a commit
that referenced
this pull request
Jan 10, 2021
…polyfill (#40370) `Object.values` is not supported in IE11 without a polyfill. The quickest, most straightfoward fix for this is to simply use `Object.keys` instead. We may want to consider including the polyfill in the CLI in the future or just wait until IE11 support is dropped before using `Object.values`. PR Close #40370
This was referenced Jan 11, 2021
|
@atscott seems that the CLI recently added the needed polyfill for |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…polyfill
Object.valuesis not supported in IE11 without a polyfill. The quickest,most straightfoward fix for this is to simply use
Object.keysinstead.We may want to consider including the polyfill in the CLI in the future
or just wait until IE11 support is dropped before using
Object.values.Fixes #40372