fix(WebWorker): Add zone support to MessageBus #4053
Conversation
jteplitz
added
action: review
jteplitz
force-pushed
the
message-bus-zone
branch
from
fc4acc5
to
51fa46e
Compare
| @@ -38,18 +40,10 @@ class MultiClientServerMessageBus implements MessageBus { | |||
| }); | |||
| } | |||
|
|
|||
| void resultReceived() { | |||
| void resultReceived(e) { | |||
There was a problem hiding this comment.
It is customary to use _ for required but unused parameters. However, in this case, why do you need the parameter?
There was a problem hiding this comment.
It needs to have a parameter so that I can pass the function directly to onResult.listen above. Without it it won't match the argument signature. I'll change it to an underscore.
jteplitz
force-pushed
the
message-bus-zone
branch
from
51fa46e
to
98650f6
Compare
|
|
||
| /** | ||
| * Assigns this bus to the given zone. | ||
| * Any channels which are set up to run in the zone will use this zone. |
There was a problem hiding this comment.
It is not clear what "use this zone" means. How about "Any callbacks attached to channels created from this [MessageBus] will be executed within the given [zone]"?
jteplitz
force-pushed
the
message-bus-zone
branch
from
98650f6
to
cda269b
Compare
| } | ||
|
|
||
| abstract class GenericMessageBusSource implements MessageBusSource { | ||
| Stream stream; |
There was a problem hiding this comment.
Do we need this field to be public?
There was a problem hiding this comment.
Can it at least be read-only?
jteplitz
force-pushed
the
message-bus-zone
branch
2 times, most recently
from
ee89542
to
43ddd3b
Compare
| /** | ||
| * Assigns this source to the given zone. | ||
| * Any channels which are set up to run in the zone will use this zone. | ||
| */ |
There was a problem hiding this comment.
Let's use similar wording as one in MessageBus.attachToZone doc comment.
yjbanov
added
pr_state: LGTM
action: cleanup
jteplitz
force-pushed
the
message-bus-zone
branch
from
43ddd3b
to
2f27472
Compare
jteplitz
removed
the
action: cleanup
jteplitz
force-pushed
the
message-bus-zone
branch
from
2f27472
to
0eafb0a
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.