Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(localize): include meaning in generated ARB files #40546

Closed
wants to merge 1 commit into from
Closed

fix(localize): include meaning in generated ARB files #40546

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

The ARB format doesn't have a dedicated field for message meaning so these changes include it as a customize attribute called x-meaning.

Fixes #40506.

@crisbeto
fix(localize): include meaning in generated ARB files
de9b08f 
The ARB format doesn't have a dedicated field for message meaning so these changes include it
as a customize attribute called `x-meaning`.

Fixes angular#40506.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n target: patch This PR is targeted for the next patch release labels Jan 24, 2021
@google-cla google-cla bot added the cla: yes label Jan 24, 2021
@ngbot ngbot bot modified the milestone: Backlog Jan 24, 2021
petebacondarwin
petebacondarwin approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @crisbeto

@petebacondarwin
Copy link
Member

I wonder whether this shoud be target: minor as it arguably is a feature?

@petebacondarwin petebacondarwin removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 24, 2021
@crisbeto
Copy link
Member Author

I don't feel strongly about it. I tagged it as a fix, because most of the other formats were exposing the meaning already.

@petebacondarwin
Copy link
Member

Fair enough. Let's land it.

@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Jan 24, 2021
jessicajaniuk pushed a commit that referenced this pull request Jan 25, 2021
@crisbeto @thePunderWoman
fix(localize): include meaning in generated ARB files (#40546)
5661298 
The ARB format doesn't have a dedicated field for message meaning so these changes include it
as a customize attribute called `x-meaning`.

Fixes #40506.

PR Close #40546
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

ARB Serializer -> missing "meaning" on extracted translation files
2 participants
@crisbeto @petebacondarwin