Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify a possible error case #40828

Closed
wants to merge 3 commits into from
Closed

Conversation

ynden
Copy link

@ynden ynden commented Feb 12, 2021

If we use a Typescript version >= 2.7, we get an error:

Property 'hero' has no initializer and is not definitely assigned in the constructor.ts(2564)

We need to inform the user of a possible solution. This is what I described.

Another solution would be to set "strictPropertyInitialization": false in tsconfig.json.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

If we use a Typescript version >= 2.7, we get an error: 
> Property 'contact' has no initializer and is not definitely assigned in the constructor.ts(2564)

This is one possible solution. Another solution would be to set `"strictPropertyInitialization": false` in `tsconfig.json`.
@google-cla
Copy link

google-cla bot commented Feb 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 12, 2021
@pullapprove pullapprove bot requested a review from IgorMinar February 12, 2021 21:48
@ynden
Copy link
Author

ynden commented Feb 12, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 12, 2021
@ynden ynden closed this Feb 12, 2021
@ynden ynden deleted the patch-1 branch February 12, 2021 22:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant