New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(aio): remove Intl
references
#40883
Conversation
93b10db
to
132e790
Compare
You can preview 93b10db at https://pr40883-93b10db.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot @dimakuba.
I think that this is probably really a refactor(platform-browser)...
type commit that has a docs change with it. Or perhaps split the PR into two PRs one refactoring and one docs.
Otherwise LGTM!
LGTM |
Since `Intl` API was dropped to use to improve browser support, would be nice to remove the references of it.
132e790
to
eb6aad9
Compare
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
eb6aad9
to
2208ff6
Compare
created separate commit |
Thanks @dimakuba for splitting the commits. Sorry to be a pedant but strictly
|
You can preview 2208ff6 at https://pr40883-2208ff6.ngbuilds.io/. |
Since `Intl` API was dropped to use to improve browser support, it is no longer needed as a polyfill to test Angular.
2208ff6
to
d0502a2
Compare
done |
You can preview d0502a2 at https://pr40883-d0502a2.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: docs-packaging-and-releasing
Since `Intl` API was dropped to use to improve browser support, would be nice to remove the references of it. PR Close #40883
Since `Intl` API was dropped to use to improve browser support, it is no longer needed as a polyfill to test Angular. PR Close #40883
Since `Intl` API was dropped to use to improve browser support, it is no longer needed as a polyfill to test Angular. PR Close #40883
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Since
Intl
API was dropped to use to improve browser support,would be nice to remove the reference from
Suggested polyfills
as well.