Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): remove Intl references #40883

Closed
wants to merge 2 commits into from

Conversation

dimakuba
Copy link
Contributor

Since Intl API was dropped to use to improve browser support,
would be nice to remove the reference from Suggested polyfills as well.

@mary-poppins
Copy link

You can preview 93b10db at https://pr40883-93b10db.ngbuilds.io/.
You can preview 132e790 at https://pr40883-132e790.ngbuilds.io/.

@ngbot ngbot bot modified the milestone: Backlog Feb 17, 2021
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot @dimakuba.
I think that this is probably really a refactor(platform-browser)... type commit that has a docs change with it. Or perhaps split the PR into two PRs one refactoring and one docs.

Otherwise LGTM!

@petebacondarwin petebacondarwin added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Feb 17, 2021
@dimakuba
Copy link
Contributor Author

You can preview 93b10db at https://pr40883-93b10db.ngbuilds.io/.
You can preview 132e790 at https://pr40883-132e790.ngbuilds.io/.

LGTM

Since `Intl` API was dropped to use to improve browser support,
would be nice to remove the references of it.
@google-cla
Copy link

google-cla bot commented Feb 17, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@dimakuba
Copy link
Contributor Author

Good spot @dimakuba.
I think that this is probably really a refactor(platform-browser)... type commit that has a docs change with it. Or perhaps split the PR into two PRs one refactoring and one docs.

Otherwise LGTM!

created separate commit

@petebacondarwin
Copy link
Member

Thanks @dimakuba for splitting the commits. Sorry to be a pedant but strictly refactor(doc-infra) would be a refactoring of the application that displays the docs. I think we want something like:

docs: remove mention of unused `Intl` polyfill

Since `Intl` API was dropped to use to improve browser support,
it is no longer needed as a polyfill to test Angular.

@mary-poppins
Copy link

You can preview 2208ff6 at https://pr40883-2208ff6.ngbuilds.io/.

Since `Intl` API was dropped to use to improve browser support,
it is no longer needed as a polyfill to test Angular.
@dimakuba
Copy link
Contributor Author

Thanks @dimakuba for splitting the commits. Sorry to be a pedant but strictly refactor(doc-infra) would be a refactoring of the application that displays the docs. I think we want something like:

docs: remove mention of unused `Intl` polyfill

Since `Intl` API was dropped to use to improve browser support,
it is no longer needed as a polyfill to test Angular.

done

@mary-poppins
Copy link

You can preview d0502a2 at https://pr40883-d0502a2.ngbuilds.io/.

@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 17, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: docs-packaging-and-releasing

@AndrewKushnir AndrewKushnir removed the request for review from IgorMinar February 17, 2021 21:49
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 17, 2021
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Feb 18, 2021
zarend pushed a commit that referenced this pull request Feb 18, 2021
Since `Intl` API was dropped to use to improve browser support,
would be nice to remove the references of it.

PR Close #40883
zarend pushed a commit that referenced this pull request Feb 18, 2021
Since `Intl` API was dropped to use to improve browser support,
it is no longer needed as a polyfill to test Angular.

PR Close #40883
@zarend zarend closed this in e7dfd7a Feb 18, 2021
zarend pushed a commit that referenced this pull request Feb 18, 2021
Since `Intl` API was dropped to use to improve browser support,
it is no longer needed as a polyfill to test Angular.

PR Close #40883
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: i18n cla: yes refactoring Issue that involves refactoring or code-cleanup target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants