Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): ensure JIT compilation of ɵɵngDeclarePipe() works #40929

Closed
wants to merge 1 commit into from
Closed

fix(compiler): ensure JIT compilation of ɵɵngDeclarePipe() works #40929

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

Previously the compiler was not evaluating the JIT compilation
of ɵɵngDeclarePipe() but there was no test to check it.

@petebacondarwin
fix(compiler): ensure JIT compilation of ɵɵngDeclarePipe() works
575b9ec 
Previously the compiler was not evaluating the JIT compilation
of `ɵɵngDeclarePipe()` but there was no test to check it.
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler compiler: linker labels Feb 20, 2021
@google-cla google-cla bot added the cla: yes label Feb 20, 2021
@ngbot ngbot bot modified the milestone: Backlog Feb 20, 2021
@pullapprove pullapprove bot requested a review from alxhub February 20, 2021 13:03
@petebacondarwin petebacondarwin removed the request for review from alxhub February 20, 2021 13:10
@pullapprove pullapprove bot requested a review from mhevery February 20, 2021 13:11
@petebacondarwin petebacondarwin requested review from alxhub and removed request for mhevery February 20, 2021 13:11
alxhub
alxhub approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love those anys :)

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 24, 2021
zarend pushed a commit that referenced this pull request Feb 24, 2021
@petebacondarwin @zarend
fix(compiler): ensure JIT compilation of ɵɵngDeclarePipe() works (#40929
55eb7b5 
)

Previously the compiler was not evaluating the JIT compilation
of `ɵɵngDeclarePipe()` but there was no test to check it.

PR Close #40929
@zarend zarend closed this in 3c24136 Feb 24, 2021
@petebacondarwin petebacondarwin deleted the linker-declare-pipe-jit-tests branch February 25, 2021 10:48
This was referenced Mar 8, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes compiler: linker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petebacondarwin @JoostK @alxhub