Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs-infra: Ivy enabled Stackblitz examples + strict mode example templates #40930

Closed
wants to merge 6 commits into from
Closed

docs-infra: Ivy enabled Stackblitz examples + strict mode example templates #40930

wants to merge 6 commits into from

Conversation

petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented Feb 20, 2021 •
edited

It appears that when we create "live" examples for Stackblitz they are set to run in ViewEngine mode.
This PR fixes that but also fixes up our examples to work with full template type checking, which will be the default for v12 CLI apps.

@google-cla google-cla bot added the cla: yes label Feb 20, 2021
@petebacondarwin petebacondarwin marked this pull request as ready for review February 20, 2021 21:36
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra labels Feb 20, 2021
@ngbot ngbot bot added this to the Backlog milestone Feb 20, 2021
@petebacondarwin petebacondarwin added the target: patch This PR is targeted for the next patch release label Feb 20, 2021
@petebacondarwin petebacondarwin changed the title Docs infra ivy stackblitz docs-infra: Ivy enabled Stackblitz examples + strict mode example templates Feb 20, 2021
@mary-poppins
Copy link

You can preview 20e04dd at https://pr40930-20e04dd.ngbuilds.io/.
You can preview cca56bf at https://pr40930-cca56bf.ngbuilds.io/.

gkalpak
gkalpak requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch with Ivy being disabled on StackBlitz 💯

(Also, yay for enabling strict templates on docs examples 🚀)

aio/tools/stackblitz-builder/builder.js Outdated Show resolved Hide resolved
aio/tools/stackblitz-builder/builder.js Outdated Show resolved Hide resolved
aio/tools/examples/shared/boilerplate/cli/tsconfig.json Show resolved Hide resolved
aio/content/examples/built-in-directives/src/app/app.component.html Outdated Show resolved Hide resolved
aio/content/examples/built-in-directives/src/app/app.component.html Show resolved Hide resolved
aio/content/guide/event-binding-concepts.md Outdated Show resolved Hide resolved
aio/content/guide/http.md Outdated Show resolved Hide resolved
aio/content/examples/getting-started/src/app/cart.service.ts Outdated Show resolved Hide resolved
aio/content/examples/getting-started/src/app/cart.service.ts Outdated Show resolved Hide resolved
aio/content/examples/template-syntax/src/app/app.component.html Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 27fe61f at https://pr40930-27fe61f.ngbuilds.io/.

@petebacondarwin petebacondarwin force-pushed the docs-infra-ivy-stackblitz branch 2 times, most recently from 6b865b2 to 54db333 Compare February 23, 2021 16:48
@mary-poppins
Copy link

You can preview 54db333 at https://pr40930-54db333.ngbuilds.io/.

@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Feb 23, 2021
@ngbot
Copy link

ngbot bot commented Feb 23, 2021

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing
    pending forbidden labels detected: action: review
    pending 4 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@petebacondarwin petebacondarwin removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 23, 2021
@petebacondarwin
build(docs-infra): enable Ivy in StackBlitz examples
63b15cf 
We need to explicitly set the `enableIvy` option in a tsconfig file
to tell StackBlitz not to use ViewEngine.

This commit will generate an appropriate tsconfig.json file in the
example data that is sent to StackBlitz, which matches the Ivy
setting of the AIO project itself.
@petebacondarwin
build(docs-infra): implement full template checking for examples
2a7c16f 
This commit turns on full template type checking and fixes the examples
that had errors.
@petebacondarwin
fixup! build(docs-infra): enable Ivy in StackBlitz examples
c4b7c3e
@petebacondarwin
fixup! build(docs-infra): implement full template checking for examples
d7b0eac
@petebacondarwin
fixup! build(docs-infra): enable Ivy in StackBlitz examples
4e7086b
@petebacondarwin
fixup! build(docs-infra): implement full template checking for examples
ebe5243
@mary-poppins
Copy link

You can preview ebe5243 at https://pr40930-ebe5243.ngbuilds.io/.

gkalpak
gkalpak approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

gkalpak
gkalpak approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global-docs-approvers

zarend pushed a commit that referenced this pull request Feb 26, 2021
@petebacondarwin @zarend
build(docs-infra): enable Ivy in StackBlitz examples (#40930)
b86d01d 
We need to explicitly set the `enableIvy` option in a tsconfig file
to tell StackBlitz not to use ViewEngine.

This commit will generate an appropriate tsconfig.json file in the
example data that is sent to StackBlitz, which matches the Ivy
setting of the AIO project itself.

PR Close #40930
zarend pushed a commit that referenced this pull request Feb 26, 2021
@petebacondarwin @zarend
build(docs-infra): implement full template checking for examples (#40930
6efd5ee 
)

This commit turns on full template type checking and fixes the examples
that had errors.

PR Close #40930
@zarend zarend closed this in 03d92f7 Feb 26, 2021
zarend pushed a commit that referenced this pull request Feb 26, 2021
@petebacondarwin @zarend
build(docs-infra): implement full template checking for examples (#40930
4859c09 
)

This commit turns on full template type checking and fixes the examples
that had errors.

PR Close #40930
@petebacondarwin petebacondarwin deleted the docs-infra-ivy-stackblitz branch March 2, 2021 11:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petebacondarwin @mary-poppins @gkalpak