Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run dartanalyzer an all files including on tests #40

Closed
mhevery opened this issue Sep 30, 2014 · 2 comments · Fixed by #55 · May be fixed by listat/angular#6 or tom-medeva/angular#4
Closed

Run dartanalyzer an all files including on tests #40

mhevery opened this issue Sep 30, 2014 · 2 comments · Fixed by #55 · May be fixed by listat/angular#6 or tom-medeva/angular#4
Assignees
@tbosch
Milestone
M1: HelloWorld

Comments

@mhevery
Copy link
Contributor

mhevery commented Sep 30, 2014

Currently the dartanalyzer does not run on test files and it runs separately for each module. We should generate a single file which references all of the files across all of the modules and then run dartanalyzer only once.

generated file: _all_.dart

export './moduleA/file1.dart';
export './moduleA/file2.dart';

export './moduleB/file1.dart';
export './moduleB/file2.dart';
@mhevery mhevery added this to the October milestone Sep 30, 2014
tbosch added a commit to tbosch/angular that referenced this issue Oct 2, 2014
@tbosch
chore(build): execute pub get only if a pubspec.yaml changed and ru…
375e6d7 
…n `dart analyzer` on all dart files

`pub get` is now only executed when the `pubspec.yaml` in the `modules`
folder is different than the `pubspec.yaml` in the `build/dart` folder.

Generates the file `build/dart/_analyzer.dart` that imports all modules
to run `dart analyzer` against all of them. The build will fail whenever
there are errors, warnings or hints in `dart analyzer`.

Changes the sources so that `dart analyzer` does not report any
error, warning or hint.

Closes angular#40
@tbosch tbosch mentioned this issue Oct 2, 2014
Merged
tbosch added a commit to tbosch/angular that referenced this issue Oct 2, 2014
@tbosch
chore(build): execute pub get only if a pubspec.yaml changed and ru…
253efe1 
…n `dart analyzer` on all dart files

`pub get` is now only executed when the `pubspec.yaml` in the `modules`
folder is different than the `pubspec.yaml` in the `build/dart` folder.

Generates the file `build/dart/_analyzer.dart` that imports all modules
to run `dart analyzer` against all of them. The build will fail whenever
there are errors, warnings or hints in `dart analyzer`.

Changes the sources so that `dart analyzer` does not report any
error, warning or hint.

Closes angular#40
tbosch added a commit to tbosch/angular that referenced this issue Oct 2, 2014
@tbosch
chore(build): execute pub get only if a pubspec.yaml changed and ru…
4ee30d1 
…n `dart analyzer` on all dart files

`pub get` is now only executed when the `pubspec.yaml` in the `modules`
folder is different than the `pubspec.yaml` in the `build/dart` folder.

Generates the file `build/dart/_analyzer.dart` that imports all modules
to run `dart analyzer` against all of them. The build will fail whenever
there are errors, warnings or hints in `dart analyzer`.

Changes the sources so that `dart analyzer` does not report any
error, warning or hint.

Closes angular#40
tbosch added a commit to tbosch/angular that referenced this issue Oct 2, 2014
@tbosch
chore(build): execute pub get only if a pubspec.yaml changed and ru…
33af1d0 
…n `dart analyzer` on all dart files

`pub get` is now only executed when the `pubspec.yaml` in the `modules`
folder is different than the `pubspec.yaml` in the `build/dart` folder.

Generates the file `build/dart/_analyzer.dart` that imports all modules
to run `dart analyzer` against all of them. The build will fail whenever
there are errors, warnings or hints in `dart analyzer`.

Changes the sources so that `dart analyzer` does not report any
error, warning or hint.

Closes angular#40
@tbosch tbosch closed this as completed in #55 Oct 2, 2014
@tbosch tbosch removed the ready label Oct 2, 2014
@tbosch
Copy link
Contributor

tbosch commented Oct 2, 2014

Generates file _analyze.dart in every module within build/dart, and runs dartanalyzer in parallel.

@avoivo avoivo mentioned this issue Jul 31, 2015
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tbosch tbosch

Labels
None yet
Projects
None yet
Milestone
M1: HelloWorld
2 participants
@mhevery @tbosch