fix(compiler-cli): ensure ngcc can handle wildcard base-paths #41033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
action: review
Ngcc uses the `paths` property to compute the potential base-paths for packages that are being processed. If the `paths` contain a wildcard `*` within a path segment, ngcc was not finding the base-path correctly. Now when a wildcard is found, there is an additional search to look for paths that might match the wildcard. Fixes angular#41014
petebacondarwin
force-pushed
the
ngcc-wildcard-basepaths
branch
from
97aefff
to
394a39f
Compare
JoostK
reviewed
Feb 28, 2021
packages/compiler-cli/ngcc/test/entry_point_finder/utils_spec.ts
Outdated
Show resolved
Hide resolved
JoostK
approved these changes
Mar 1, 2021
petebacondarwin
added
action: merge
gkalpak
requested changes
Mar 1, 2021
petebacondarwin
added
action: cleanup
petebacondarwin
added
action: review
petebacondarwin
added
action: merge
zarend
pushed a commit
that referenced
this pull request
Mar 1, 2021
Ngcc uses the `paths` property to compute the potential base-paths for packages that are being processed. If the `paths` contain a wildcard `*` within a path segment, ngcc was not finding the base-path correctly. Now when a wildcard is found, there is an additional search to look for paths that might match the wildcard. Fixes #41014 PR Close #41033
This was referenced Mar 8, 2021
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ngcc uses the
pathsproperty to compute the potential base-pathsfor packages that are being processed. If the
pathscontain a wildcard*within a path segment, ngcc was not finding the base-path correctly.Now when a wildcard is found, there is an additional search to look for
paths that might match the wildcard.
Fixes #41014