fix(compiler): recover from an incomplete open tag at the end of a file #41054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
state: WIP
target: patch
The compiler's parsing code has logic to recover from incomplete open tags (i.e. `<div`) but the recovery logic does not handle when the incomplete tag is terminated by an EOF. This commit updates the logic to allow for the EOF character to be interpreted as the end of the tag open so that the parser can continue processing. It will then fail to find the end tag and recover by marking the open tag as incomplete. Part of angular/vscode-ng-language-service#1140
atscott
added
action: review
alxhub
approved these changes
Mar 2, 2021
atscott
added
action: merge
|
merge assistance: This is approved but the checks are saying there's a pending review |
zarend
pushed a commit
that referenced
this pull request
Mar 3, 2021
…le (#41054) The compiler's parsing code has logic to recover from incomplete open tags (i.e. `<div`) but the recovery logic does not handle when the incomplete tag is terminated by an EOF. This commit updates the logic to allow for the EOF character to be interpreted as the end of the tag open so that the parser can continue processing. It will then fail to find the end tag and recover by marking the open tag as incomplete. Part of angular/vscode-ng-language-service#1140 PR Close #41054
This was referenced Mar 8, 2021
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler's parsing code has logic to recover from incomplete open
tags (i.e.
<div) but the recovery logic does not handle when theincomplete tag is terminated by an EOF. This commit updates the logic to
allow for the EOF character to be interpreted as the end of the tag open
so that the parser can continue processing. It will then fail to find
the end tag and recover by marking the open tag as incomplete.
Part of angular/vscode-ng-language-service#1140