Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): remove attributes when expression in [attr.foo]='exp' … #4163

Closed

Conversation

pkozlowski-opensource
Copy link
Member

…evaluates to null

Fixes #4150

@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 13, 2015
@pkozlowski-opensource
Copy link
Member Author

@kegluneq this fixes a regression introduced in 6c3c606 but since there is no test for the mentioned patch I'm not sure if I'm not re-introducing the issue you were trying to fix originally. Would be awesome to have your input.

@kegluneq
Copy link

The original issue had to do with the type signature of setElementAttribute where the attribute value is declared as a string. Passing non-string to it caused exceptions.

This change lgtm.

@vicb vicb added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Sep 15, 2015
@mary-poppins
Copy link

Merging PR #4163 on behalf of @vicb to branch presubmit-vicb-pr-4163.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 15, 2015
@vicb vicb removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 15, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean attributes stopped working
6 participants