Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-infra: potential improvements in generated JSON files for docs #43517

Closed
2 tasks
gkalpak opened this issue Sep 20, 2021 · 1 comment
Closed
2 tasks

docs-infra: potential improvements in generated JSON files for docs #43517

gkalpak opened this issue Sep 20, 2021 · 1 comment

Comments

@gkalpak
Copy link
Member

gkalpak commented Sep 20, 2021

Description

While investigating #28114, we found out about the following potential improvements to the generated JSON files (/generated/docs/**/*.json). See also #28114 (comment).

  • The renderLinkInfo Dgeni processor renders an HTML comment with all links found in the document at the bottom of the HTML content. This unnecessarily increases the payload size of each document (which affects both the download times and the cache sizes for the SW).
    (NOTE: Since we include two links (view/edit) for each property/method/overload signature, some API docs end up with a lot of such links.)

  • The URLs for the links to view/edit the source code on GitHub contain the current version of Angular (see the githubViewRef() macro). This means that on every release (including patch releases), the contents of almost all docs files change, thus invalidating their content-based hashes (and by extension invalidating any cached versions of the files).
    Potential fixes:

What is the affected URL?

Almost all 😁

Please provide the steps to reproduce the issue

No response

Please provide the expected behavior vs the actual behavior you encountered

No response

Please provide a screenshot if possible

No response

Please provide the exception or error you saw

No response

Is this a browser-specific issue? If so, please specify the device, browser, and version.

No response

@ngbot ngbot bot modified the milestone: needsTriage Sep 20, 2021
@gkalpak gkalpak added this to BACKLOG in docs-infra Sep 20, 2021
@JeanMeche JeanMeche closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
docs-infra
BACKLOG
Development

No branches or pull requests

2 participants