Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Node v4 #4375

Closed
wants to merge 12 commits into from
Closed

Upgrade to Node v4 #4375

wants to merge 12 commits into from

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@IgorMinar
Copy link
Contributor Author

@alexeagle I fixed the build failures, so maybe the build is going to pass now. fingers crossed

@jelbourn I'm upgrading sass dependency because the old one doesn't work with node 4. are you ok with this (material is the only module using sass so I can't estimate the impact)

@jelbourn
Copy link
Member

SGTM. As long as the tests pass everything should be fine.

mgol
mgol reviewed Sep 29, 2015
View reviewed changes
.travis.yml
@@ -1,7 +1,7 @@
language: node_js
sudo: false
node_js:
- '0.12'
- '4.1.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want to pin it that much? 0.12 was a range (currently matching 0.12.7).

Related: angular/protractor#2543

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to ensure that ci uses the same version as what we use locally. So my preference is to pin it down to an exact version and update that once in a while. (especially since newer node version could update npm and cause conflicts...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, makes sense, I guess. We can still use a newer version locally but CI might be more stable when no unplanned Node update happens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

On Wed, Sep 30, 2015 at 3:18 PM Michał Gołębiowski notifications@github.com
wrote:

In .travis.yml
#4375 (comment):

@@ -1,7 +1,7 @@
language: node_js
sudo: false
node_js:
-- '0.12'
+- '4.1.1'

Hmm, makes sense, I guess. We can still use a newer version locally but CI
might be more stable when no unplanned Node update happens.

—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular/pull/4375/files#r40859889.

@IgorMinar IgorMinar force-pushed the node-v4 branch 2 times, most recently from 8f578d0 to 68221ec Compare October 3, 2015 16:46
@IgorMinar
build(travis): bump node version to 4.1.1 and npm to 2.14.5
648d0b3
@IgorMinar
build(gulp): bump check-environment node version to 4.1.1 and npm to …
24d89d7 
…2.14.5
@IgorMinar
build(npm): update chokidar and karma* dependencies
8c2d29c 
These dependencies required upgrade in order for us to run on Node v4.x

chokidar 1.0.1 -> 1.1.0
karma 0.12.23 -> 0.13.10
karma-chorome-launcher 0.1.8 -> 0.2.0
karma-cli 0.0.4 -> 0.1.0
karma-dart 0.2.8 -> 0.3.0
karma-sauce-launcher 0.2.11 -> 0.2.14
@IgorMinar
build(npm): upgrade gulp-sass to v2.0.4
192ccdd
@IgorMinar
build(npm): resolve shrinkwrap conflicts after rebase
47b0394
@IgorMinar
fix(tslint): fix d.ts file paths for node_modules dependencies
dec80ad
@IgorMinar
fix(karma-dart-evalcache): make the code compatible with karma 0.13.x
7306914
@IgorMinar
fix(karma): socket.io 1.x transport is now called 'polling' instead o…
d0b10d9 
…f 'xhr-polling'

And we really need it only when using sauce, so I'm making the condition more strict.
@IgorMinar
test(tools): temporarily disable tests that depend on mock-fs
16213e0 
mock-fs is currently incompatible with node 4.x, but a fix is in progress
tschaub/mock-fs#59

Since we are currently not actively developing the affected broccoli plugins,
the risk of disabling these tests is low, especially in the light of
improvements we get from node 4.x.
@IgorMinar
style(gulp): make code more readable
5f5f304
@IgorMinar
build(travis): add travis log folding for verbose tasks
5bb2057
@IgorMinar
Copy link
Contributor Author

all karma problems are now resolved thanks to @zzo!! Merging!

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Oct 3, 2015
@mary-poppins
Copy link

Merging PR #4375 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4375.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 3, 2015
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed state: WIP labels Oct 3, 2015
@mary-poppins
Copy link

Merging PR #4375 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4375.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 3, 2015
@IgorMinar IgorMinar closed this in 758efba Oct 3, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alexeagle alexeagle

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@IgorMinar @jelbourn @mary-poppins @mgol @alexeagle @googlebot