Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing release of zone.js along with Angular 14.0.0 #46230

Closed
Platonn opened this issue Jun 2, 2022 · 7 comments
Closed

Missing release of zone.js along with Angular 14.0.0 #46230

Platonn opened this issue Jun 2, 2022 · 7 comments
Assignees
Milestone

Comments

@Platonn
Copy link
Contributor

Platonn commented Jun 2, 2022

Which @angular/* package(s) are the source of the bug

I wouldn’t call it a bug strictly, but those are the related packages:
@angular/core, zone.js

Is this a regression?

No

Description

Angular 14.0.0 Changelog mentions some changes in zone.js (related to this commit f19b36f), however new version of zone.js was not released yet.

By any chance, do you plan to release new zone.js@0.11.6 (or 0.12.0?) and point it as a peerDependency of angular/core@14.0.1?

If not, I think we should remove the zone.js changes from Angular 14 changelog.

cc @JiaLiPassion

Please provide a link to a minimal reproduction of the bug

N/A

Please provide the exception or error you saw

N/A

Please provide the environment you discovered this bug in (run ng version)

Angular 14.0.0

Anything else?

I’m not sure if the issue template for bug is appropriate for this issue, but other templates like “feature request” or “docs” didn’t look more appropriate to me.

@Platonn
Copy link
Contributor Author

Platonn commented Jun 8, 2022

Hi @alxhub would you mind explaining why this issue was closed?
I can see the PR #46232 by @JiaLiPassion is not merged and zone.js@0.11.6 was not released yet.

@dylhunn dylhunn reopened this Jun 13, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Jun 14, 2022

@Platonn We intended to release zone.js@0.11.6 as well; I think Alex is working on getting it released soon.

@Julien-Marcou
Copy link
Contributor

A new angular version has just been released, but it's still missing the zone.js release (despite the merge of #46232 before the release of the new angular version), is it expected ?

@dylhunn
Copy link
Contributor

dylhunn commented Jun 15, 2022

@Julien-Marcou No, this was a mistake. #46232 was just merged, and I think that @alxhub is releasing zone.js soon (correct me if I'm wrong)

@Julien-Marcou
Copy link
Contributor

Julien-Marcou commented Jun 15, 2022

It is now available 👍 this issue can be closed 😄

@dylhunn dylhunn closed this as completed Jun 15, 2022
@Platonn
Copy link
Contributor Author

Platonn commented Jun 15, 2022

Thank you @JiaLiPassion for cutting off the release branch and thank you folks for releasing zone.js@0.11.6 🙌

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants