fix(compiler): shadow CSS @import test in some browsers #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclaval
force-pushed
the
fixShadowCSSImport
branch
from
f19fa0d
to
7290ab9
Compare
marclaval
added
the
action: review
| var css = s(styleStr, 'a'); | ||
| expect(css).toEqual(styleStr); | ||
| }); | ||
| // Can't work in Firefox, see https://bugzilla.mozilla.org/show_bug.cgi?id=625013 |
There was a problem hiding this comment.
Could you qualify this comment with TODO: so we can find it later and fix it?
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test ShadowCss should pass through @import directives is failing in some browsers: Firefox, old Androids (< 4.4) and all IEs.
Firefox
Expected '' to equal '@import url("https://fonts.googleapis.com/css?family=Roboto");'.Android
Expected '@import url("https://fonts.googleapis.com/css?family=Roboto") ;' to equal '@import url("https://fonts.googleapis.com/css?family=Roboto");'.IE
Expected '@import url( https://fonts.googleapis.com/css?family=Roboto );' to equal '@import url("https://fonts.googleapis.com/css?family=Roboto");'.For Android and IE, it is a matter of quotes and white spaces, so only the
normalizeCSSfunction has to be updated.For Firefox, it is more complex. Test has been deactivated and a follow-up issue has been opened: #4628