Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ngUpgrade): support for content project from ng1->ng2 #4640

Closed
wants to merge 3 commits into from
Closed

feat(ngUpgrade): support for content project from ng1->ng2 #4640

wants to merge 3 commits into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Oct 9, 2015

No description provided.

tbosch
tbosch reviewed Oct 9, 2015
View reviewed changes
modules/upgrade/src/ng2_facade.ts
}

bootstrapNg2() {
bootstrapNg2(): Node {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Store internally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 9, 2015
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 9, 2015
@mary-poppins
Copy link

Merging PR #4640 on behalf of @mhevery to branch presubmit-mhevery-pr-4640.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 9, 2015
@mhevery mhevery closed this in 19c1bd7 Oct 10, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mhevery @mary-poppins @tbosch @googlebot