fix(publish): emit type declarations with CJS build

[jeffbcross]

Closes #4706

[jeffbcross]

The problem was that our npm publish script is copying output from dist/js/cjs, which is generated from the Node broccoli tree, instead of from dist/js/prod/es5, where the typings were correctly generated from our broccoli build.

I fixed this by changing the Node tree to emit type declarations, which seems like a safe change (with hopefully very little latency added to our cjs build). The other way I could have fixed this would have been to change the npm_publish script to copy files from dist/js/prod/es5 instead of dist/js/cjs, but I'm unsure of the impact of that change since there are many subtle differences between the two outputs. For example, the prod output of angular2.js includes import "./manual_typings/globals.d.ts"; which the node/cjs output does not include.

Here is a screenshot of the diff of the npm folder before making this change (left), and after making this change (right). Notice the lovely d.ts files included on the right.

[jeffbcross]

@alexeagle and I are going to make a couple more changes to the Node Tree to get the output we need.

• Add manual_typings to the output
• Add a step in the Node tree to rewrite angular.d.ts to include an import to manual_typings/globals.d.ts.

[mary-poppins]

Merging PR #4708 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-4708.

[alexeagle]

Reviewed in person. Thanks Jeff!!

On Tue, Oct 13, 2015 at 3:16 PM Mary Poppins notifications@github.com
wrote:

Merging PR #4708 #4708 on behalf
of @jeffbcross https://github.com/jeffbcross to branch
presubmit-jeffbcross-pr-4708
https://github.com/angular/angular/tree/presubmit-jeffbcross-pr-4708.

—
Reply to this email directly or view it on GitHub
#4708 (comment).

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}