New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(benchmarks): update react and polymer benchmarks and get tree upd… #4709
Conversation
it('should log the stats (update)', function(done) { | ||
runClickBenchmark({ | ||
url: URL, | ||
buttons: ['#createDom'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the correct button?
If you think you're pressing the right buttons, then LGTM&merge. |
03cc2e1
to
b08a7ab
Compare
Closes #960 |
Blocked by the router not working in Angular 1.4 |
"resolved": "https://registry.npmjs.org/angular/-/angular-1.3.5.tgz" | ||
"version": "1.4.7", | ||
"from": "angular@1.4.7", | ||
"resolved": "https://registry.npmjs.org/angular/-/angular-1.4.7.tgz" | ||
}, | ||
"angular-animate": { | ||
"version": "1.3.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you forgot to bump the other angular-*
packages, which is why the router tests fail.
…ate numbers for all of the benchmarks as well.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…ate numbers for all of the benchmarks as well.