Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework bootstrapping, imports and bundles. #4834

Closed
11 tasks done
mhevery opened this issue Oct 20, 2015 · 3 comments
Closed
11 tasks done

Rework bootstrapping, imports and bundles. #4834

mhevery opened this issue Oct 20, 2015 · 3 comments
Assignees
Labels
area: packaging Issues related to Angular's creation of npm packages effort3: weeks feature Issue that requests a new feature
Milestone

Comments

@mhevery
Copy link
Contributor

mhevery commented Oct 20, 2015

Full design doc.

  • Support configuring of platform Directives/Pipes. Support configuring of global Directives/Pipes #4857
  • Have PlatformRef inject EAGER_SERVICES so that we can auto-init Reflector
  • Refactor so that we bootstrap using DI bundles.
    • boostrap(c, b) => platform([BROWSER]).application([HTTP, ROUTER, b]).component(c)
  • Realign imports
    • Rename all FOO_PROVIDERS to FOO. (to make the bootstrap process less verbose) Update: we decided not to do this
    • Move imports per this spreadsheet.
  • Create platform bundles
    • SFX bundles which exports to ng namespace in additive fashion.
    • commonJS bundle.
    • all bundle which contains bootstrap
@mhevery mhevery added feature Issue that requests a new feature P1: urgent effort3: weeks area: packaging Issues related to Angular's creation of npm packages labels Oct 20, 2015
@btford btford mentioned this issue Oct 23, 2015
@naomiblack naomiblack changed the title Rework bootstraping, imports and bundles. Rework bootstrapping, imports and bundles. Oct 26, 2015
@mhevery mhevery modified the milestone: Beta Oct 27, 2015
@pkozlowski-opensource
Copy link
Member

I believe that our UMD bundles could replace the current SFX bundles as they are already doing what is described in this issue. I would suggest "killing" our existing sfx bundles and keep umd ones only.

@IgorMinar I did some work on this topic and could continue, but maybe there is another plan here since it was assigned to you.

@pkozlowski-opensource
Copy link
Member

I believe that this is now fixed via fb4f1e8 - we've got one UMD bundle that acts as SFX, exports things on the ng.* namespace and works for browser platform.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: packaging Issues related to Angular's creation of npm packages effort3: weeks feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests

4 participants