Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ChangeDetector): support for NaN #4853

Closed
wants to merge 1 commit into from
Closed

fix(ChangeDetector): support for NaN #4853

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Oct 21, 2015

No description provided.

@vicb vicb added type: bug/fix comp: core/change_detection action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 21, 2015
vsavkin
vsavkin reviewed Oct 27, 2015
View reviewed changes
modules/angular2/src/core/change_detection/change_detection_util.ts
@@ -202,4 +209,6 @@ export class ChangeDetectionUtil {
static directiveIndex(elementIndex: number, directiveIndex: number): DirectiveIndex {
return new DirectiveIndex(elementIndex, directiveIndex);
}

static looseNotIdentical(a: any, b: any): boolean { return !looseIdentical(a, b); }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to have looseNotIdentical or just calling !notIdentical is good enough?

If we do, can you change DynamicChangeDetector to use it too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looseNotIdentical comes from a comment by @mhevery in the Dart pregen PR to avoid avoid to repeat !looseIdentical everywhere (in the generated code)

Now we are consistent by having looseNotIdentical everywhere - instead of having it only for Dart.

@vsavkin vsavkin added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 27, 2015
@vsavkin vsavkin assigned vicb and unassigned vsavkin Oct 27, 2015
@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Oct 27, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 27, 2015
@mary-poppins
Copy link

Merging PR #4853 on behalf of @vicb to branch presubmit-vicb-pr-4853.

@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Oct 28, 2015
@mary-poppins
Copy link

Merging PR #4853 on behalf of @vicb to branch presubmit-vicb-pr-4853.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 28, 2015
@vicb vicb closed this in 1316c3e Oct 28, 2015
@vicb vicb deleted the 1021-looseId branch October 28, 2015 01:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@vicb vicb

Labels
cla: yes type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vicb @mary-poppins @vsavkin @googlebot