fix(common): warn if using ngSrcset without a configured image loader

[Ivnosing]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: #48655

What is the new behavior?

A warn is logged when the attribute ngSrcset is used but no loader is configured.

Does this PR introduce a breaking change?

• Yes
• No

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[Ivnosing]

Is there anything else I could do for pipelines that threw an error or failed? 🙂 I'm not sure what are the issues there.

[alan-agius4]

Looks like one of the tests is failing

//packages/core/test/bundling/image-directive:protractor_tests_chromium  FAILED in 2 out of 2 in 13.0s

Failures:
1) NgOptimizedImage directive should not warn if there is no oversized image
  Message:
    Expected 1 to equal 0.
  Stack:
    Error: Failed expectation
        at /b/f/w/bazel-out/k8-fastbuild/bin/packages/core/test/bundling/packages/core/test/bundling/image-directive/e2e/oversized-image/oversized-image.e2e-spec.ts:19:25
        at Generator.next (<anonymous>)
        at fulfilled (/b/f/w/bazel-out/k8-fastbuild/bin/packages/core/test/bundling/image-directive/protractor_tests_chromium.sh.runfiles/angular/packages/core/test/bundling/image-directive/protractor_tests_bundle_spec.js:35:26)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)

[AndrewKushnir]

@Ivnosing thanks for the PR 👍 The changes look good, I've just left a minor comment.

[AndrewKushnir]

@Ivnosing as @alan-agius4 mentioned above, there is a CI failure, potentially related to these changes, where there is an extra console warning in one of the tests. I believe you may need to update the packages/core/test/bundling/image-directive/e2e/oversized-image/oversized-image.ts file and configure a loader there, for example:

providers: [
  {provide: IMAGE_LOADER, useFactory: () => (config: ImageLoaderConfig) => config.src}
]

Please let us know if you have any questions.

[AndrewKushnir]

@Ivnosing thanks for addressing the feedback! When you get a chance, could you please merge all commits into one, so that we can proceed with the final stages of the code review process? Thank you.

[Ivnosing]

@AndrewKushnir @alan-agius4 thanks for the feedback and support!

[AndrewKushnir]

Reviewed-for: public-api

[AndrewKushnir]

Presubmit.

[jessicajaniuk]

reviewed-for: public-api

[jessicajaniuk]

reviewed-for: public-api

[AndrewKushnir]

Caretaker note: unrelated presubmit failures, the PR is ready for merge.

[jessicajaniuk]

This PR was merged into the repository by commit a055196.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}