New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add ng generate schematic to convert to standalone bootstrapping APIs #48848

Closed

crisbeto wants to merge 2 commits into angular:main from crisbeto:standalone-migration-bootstrap

Member

crisbeto commented Jan 26, 2023

Adds the final step to the standalone schematic that converts the root component to standalone and the bootstrapModule to bootstrapApplication. Also adds a readme.

crisbeto added action: review area: core area: migrations target: minor labels

ngbot bot added this to the Backlog milestone

angular-robot bot added detected: feature area: docs labels

crisbeto mentioned this pull request

ng g @angular/core:standalone only updates test files in a CLI project #48844

Closed

crisbeto force-pushed the standalone-migration-bootstrap branch from daa3e32 to c4813a0 Compare

January 26, 2023 08:51

crisbeto requested a review from devversion

January 26, 2023 09:09

crisbeto marked this pull request as ready for review

January 26, 2023 09:09

devversion reviewed

View reviewed changes

Member

devversion left a comment

A couple of comments. Will finish small remaining parts in a few minutes

packages/core/schematics/ng-generate/standalone-migration/README.md Outdated Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/README.md Outdated Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/README.md Outdated Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/README.md Outdated Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Outdated Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts

+               * Whether a node is exported.
+               * @param node Node to be checked.
+               */
+              function isExported(node: ts.Node): node is ts.Node {

Member

devversion Jan 26, 2023

This does not handle exports which aren't done through the modifier. e.g.

const bla = true;

export {bla}

Type checker has a way of getting module exports for a file. I don't know if that's a case we need to support though.

Member Author

crisbeto Jan 26, 2023

I think that's a bit of an edge case that should be fairly easy to fix manually. I was trying to capture the most common cases.

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

devversion approved these changes

View reviewed changes

Member

devversion left a comment

LGTM overall, a couple of final comments along with the previous ones.

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Outdated Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Outdated Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Outdated Show resolved Hide resolved

crisbeto added 2 commits

January 26, 2023 17:35


          feat(core): add ng generate schematic to convert to standalone bootst…

72d2db5

…rapping APIs

Adds a new mode to the `@angular/core:standalone` schematic that allows users to switch from `bootstrapModule` to `bootstrapApplication`, as well as `provideRouter`, `provideAnimations` and `provideNoopAnimations`.


          docs(core): add readme for standalone migration

09aa6ec

Updates the readme for the standalone migration to describe the process and the different transformations that are happening.

crisbeto force-pushed the standalone-migration-bootstrap branch from c4813a0 to 09aa6ec Compare

January 26, 2023 16:35

crisbeto commented

View reviewed changes

Member Author

crisbeto left a comment

Feedback has been addressed.

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Outdated Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts

+               * Whether a node is exported.
+               * @param node Node to be checked.
+               */
+              function isExported(node: ts.Node): node is ts.Node {

Member Author

crisbeto Jan 26, 2023

I think that's a bit of an edge case that should be fairly easy to fix manually. I was trying to capture the most common cases.

packages/core/schematics/ng-generate/standalone-migration/standalone-bootstrap.ts Show resolved Hide resolved

crisbeto added action: merge and removed action: review labels

devversion approved these changes

View reviewed changes

Contributor

jessicajaniuk commented Jan 26, 2023

This PR was merged into the repository by commit ed8f701.

jessicajaniuk closed this in

345e737

jessicajaniuk pushed a commit that referenced this pull request


          docs(core): add readme for standalone migration (#48848)

ed8f701

Updates the readme for the standalone migration to describe the process and the different transformations that are happening.

PR Close #48848

cexbrayat reviewed

View reviewed changes

Member

cexbrayat left a comment

@crisbeto Reading the readme, I had two questions, but the PR landed before I got to submit them. If my comments make sense, I can open a PR to fix this (but maybe I misunderstood something)

packages/core/schematics/ng-generate/standalone-migration/README.md

+              // declarer.module.ts
+              @NgModule({
+                declarations: [FooComp, BarPipe],

Member

cexbrayat Jan 26, 2023

Maybe I'm misunderstanding something, but if this module has declarations, then it should not be deleted right? So maybe you meant imports?

Member Author

crisbeto Jan 26, 2023

Yeah, this should be imports. I'll fix it up together with the other bugs.

packages/core/schematics/ng-generate/standalone-migration/README.md

+              ```typescript
+              // index.ts
+              export {DeclarerModule} from './modules/index';
+              ```

Member

cexbrayat Jan 26, 2023

no TODO added in that case?

Member Author

crisbeto Jan 26, 2023

Actually I think that only the export of ConfigurerModule would be left here.

crisbeto added a commit to crisbeto/angular that referenced this pull request


          docs(migrations): follow-up readme fixes

49af70e

Addresses a couple of notes from angular#48848 that came in after the PR was merged.

jessicajaniuk pushed a commit that referenced this pull request


          docs(migrations): follow-up readme fixes (#48866)

c865b8b

Addresses a couple of notes from #48848 that came in after the PR was merged.

PR Close #48866

trekladyone pushed a commit to trekladyone/angular that referenced this pull request


          feat(core): add ng generate schematic to convert to standalone bootst…

a4104a5

…rapping APIs (angular#48848)

Adds a new mode to the `@angular/core:standalone` schematic that allows users to switch from `bootstrapModule` to `bootstrapApplication`, as well as `provideRouter`, `provideAnimations` and `provideNoopAnimations`.

PR Close angular#48848

trekladyone pushed a commit to trekladyone/angular that referenced this pull request


          docs(core): add readme for standalone migration (angular#48848)

93a5bf8

Updates the readme for the standalone migration to describe the process and the different transformations that are happening.

PR Close angular#48848

trekladyone pushed a commit to trekladyone/angular that referenced this pull request


          docs(migrations): follow-up readme fixes (angular#48866)

c69adb8

Addresses a couple of notes from angular#48848 that came in after the PR was merged.

PR Close angular#48866

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request


          Update angular monorepo to v15.2.0 (#1793)

43c700e

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | minor | [`15.1.5` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.1.5/15.2.0) |
| [@angular/common](https://github.com/angular/angular) | dependencies | minor | [`15.1.5` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.1.5/15.2.0) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | minor | [`15.1.5` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.1.5/15.2.0) |
| [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | minor | [`15.1.5` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.1.5/15.2.0) |
| [@angular/core](https://github.com/angular/angular) | dependencies | minor | [`15.1.5` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.1.5/15.2.0) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | minor | [`15.1.5` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.1.5/15.2.0) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | minor | [`15.1.5` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.1.5/15.2.0) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | minor | [`15.1.5` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.1.5/15.2.0) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v15.2.0`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1520-2023-02-22)

[Compare Source](angular/angular@15.1.5...15.2.0)

#### Deprecations

#####

-   Class and `InjectionToken` guards and resolvers are
    deprecated. Instead, write guards as plain JavaScript functions and
    inject dependencies with `inject` from `@angular/core`.

#####

| Commit | Type | Description |
| -- | -- | -- |
| [926c35f4ac](angular/angular@926c35f) | docs | Deprecate class and InjectionToken and resolvers ([#&#8203;47924](angular/angular#47924)) |

##### common

| Commit | Type | Description |
| -- | -- | -- |
| [54b24eb40f](angular/angular@54b24eb) | feat | Add loaderParams attribute to NgOptimizedImage ([#&#8203;48907](angular/angular#48907)) |

##### compiler-cli

| Commit | Type | Description |
| -- | -- | -- |
| [0cf11167f1](angular/angular@0cf1116) | fix | incorrectly detecting forward refs when symbol already exists in file ([#&#8203;48988](angular/angular#48988)) |

##### core

| Commit | Type | Description |
| -- | -- | -- |
| [a154db8a81](angular/angular@a154db8) | feat | add ng generate schematic to convert declarations to standalone ([#&#8203;48790](angular/angular#48790)) |
| [345e737daa](angular/angular@345e737) | feat | add ng generate schematic to convert to standalone bootstrapping APIs ([#&#8203;48848](angular/angular#48848)) |
| [e7318fc758](angular/angular@e7318fc) | feat | add ng generate schematic to remove unnecessary modules ([#&#8203;48832](angular/angular#48832)) |

##### language-service

| Commit | Type | Description |
| -- | -- | -- |
| [4ae384fd61](angular/angular@4ae384f) | feat | Allow auto-imports of a pipe via quick fix when its selector is used, both directly and via reexports. ([#&#8203;48354](angular/angular#48354)) |
| [141333411e](angular/angular@1413334) | feat | Introduce a new NgModuleIndex, and use it to suggest re-exports. ([#&#8203;48354](angular/angular#48354)) |
| [d0145033bd](angular/angular@d014503) | fix | generate forwardRef for same file imports ([#&#8203;48898](angular/angular#48898)) |

##### migrations

| Commit | Type | Description |
| -- | -- | -- |
| [2796230e95](angular/angular@2796230) | fix | add `enum` in `mode` option in `standalone` schema ([#&#8203;48851](angular/angular#48851)) |
| [816e76a578](angular/angular@816e76a) | fix | automatically prune root module after bootstrap step ([#&#8203;49030](angular/angular#49030)) |
| [bdbf21d04b](angular/angular@bdbf21d) | fix | avoid generating imports with forward slashes ([#&#8203;48993](angular/angular#48993)) |
| [32cf4e5cb9](angular/angular@32cf4e5) | fix | avoid internal modules when generating imports ([#&#8203;48958](angular/angular#48958)) |
| [521ccfbe6c](angular/angular@521ccfb) | fix | avoid interrupting the migration if language service lookup fails ([#&#8203;49010](angular/angular#49010)) |
| [a40cd47aa7](angular/angular@a40cd47) | fix | avoid modifying testing modules without declarations ([#&#8203;48921](angular/angular#48921)) |
| [1afa6ed322](angular/angular@1afa6ed) | fix | don't add ModuleWithProviders to standalone test components ([#&#8203;48987](angular/angular#48987)) |
| [c98c6a8452](angular/angular@c98c6a8) | fix | don't copy animations modules into the imports of test components ([#&#8203;49147](angular/angular#49147)) |
| [8389557848](angular/angular@8389557) | fix | don't copy unmigrated declarations into imports array ([#&#8203;48882](angular/angular#48882)) |
| [f82bdc4b01](angular/angular@f82bdc4) | fix | don't delete classes that may provide dependencies transitively ([#&#8203;48866](angular/angular#48866)) |
| [759db12e0b](angular/angular@759db12) | fix | duplicated comments on migrated classes ([#&#8203;48966](angular/angular#48966)) |
| [ba38178d19](angular/angular@ba38178) | fix | generate forwardRef for same file imports ([#&#8203;48898](angular/angular#48898)) |
| [03fcb36cfd](angular/angular@03fcb36) | fix | migrate HttpClientModule to provideHttpClient() ([#&#8203;48949](angular/angular#48949)) |
| [2de6dae16d](angular/angular@2de6dae) | fix | migrate RouterModule.forRoot with a config object to use features ([#&#8203;48935](angular/angular#48935)) |
| [770191cf1f](angular/angular@770191c) | fix | migrate tests when switching to standalone bootstrap API ([#&#8203;48987](angular/angular#48987)) |
| [c7926b5773](angular/angular@c7926b5) | fix | move standalone migrations into imports ([#&#8203;48987](angular/angular#48987)) |
| [65c74ed93e](angular/angular@65c74ed) | fix | normalize paths to posix ([#&#8203;48850](angular/angular#48850)) |
| [6377487b1a](angular/angular@6377487) | fix | only exclude bootstrapped declarations from initial standalone migration ([#&#8203;48987](angular/angular#48987)) |
| [e9e4449a43](angular/angular@e9e4449) | fix | preserve tsconfig in standalone migration ([#&#8203;48987](angular/angular#48987)) |
| [ffad1b49d9](angular/angular@ffad1b4) | fix | reduce number of files that need to be checked ([#&#8203;48987](angular/angular#48987)) |
| [ba7a757cc5](angular/angular@ba7a757) | fix | return correct alias when conflicting import exists ([#&#8203;49139](angular/angular#49139)) |
| [49a7c9f94a](angular/angular@49a7c9f) | fix | standalone migration incorrectly throwing path error for multi app projects ([#&#8203;48958](angular/angular#48958)) |
| [584976e6c8](angular/angular@584976e) | fix | support --defaults in standalone migration ([#&#8203;48921](angular/angular#48921)) |
| [03f47ac901](angular/angular@03f47ac) | fix | use consistent quotes in generated imports ([#&#8203;48876](angular/angular#48876)) |
| [ebae506d89](angular/angular@ebae506) | fix | use import remapper in root component ([#&#8203;49046](angular/angular#49046)) |
| [40c976c909](angular/angular@40c976c) | fix | use NgForOf instead of NgFor ([#&#8203;49022](angular/angular#49022)) |
| [4ac25b2aff](angular/angular@4ac25b2) | perf | avoid re-traversing nodes when resolving bootstrap call dependencies ([#&#8203;49010](angular/angular#49010)) |
| [26cb7ab2e6](angular/angular@26cb7ab) | perf | speed up language service lookups ([#&#8203;49010](angular/angular#49010)) |

##### platform-browser

| Commit | Type | Description |
| -- | -- | -- |
| [bf4ad38117](angular/angular@bf4ad38) | fix | remove styles from DOM of destroyed components ([#&#8203;48298](angular/angular#48298)) |

##### platform-server

| Commit | Type | Description |
| -- | -- | -- |
| [25e220a23a](angular/angular@25e220a) | fix | avoid duplicate TransferState info after renderApplication call ([#&#8203;49094](angular/angular#49094)) |

##### router

| Commit | Type | Description |
| -- | -- | -- |
| [31b94c762f](angular/angular@31b94c7) | feat | Add a withNavigationErrorHandler feature to provideRouter ([#&#8203;48551](angular/angular#48551)) |
| [dedac8d3f7](angular/angular@dedac8d) | feat | Add test helper for trigger navigations in tests ([#&#8203;48552](angular/angular#48552)) |

#### Special Thanks

Alan Agius, Alex Castle, Alex Rickabaugh, Andrew Kushnir, Andrew Scott, Dylan Hunn, Ikko Eltociear Ashimine, Ilyass, Jessica Janiuk, Joey Perrott, John Manners, Kalbarczyk, Kristiyan Kostadinov, Matthieu Riegler, Paul Gschwendtner, Pawel Kozlowski, Virginia Dooley, Walid Bouguima, cexbrayat and mgechev

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDkuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1Mi4wIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1793
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot bot commented Feb 26, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-automatic-lock-bot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.