-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(migrations): migration host incorrectly reading empty files #48849
Conversation
Fixes that the migration host was doing a basic falsy check if the content was read correctly which meant that a component with an empty template would be considered as having a missing template file. Fixes angular#48846.
9033c55
to
0007b67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The explicit undefined check seems fine, but either way is fine
I switched it to |
This PR was merged into the repository by commit 04e0ac3. |
…lar#48849) Fixes that the migration host was doing a basic falsy check if the content was read correctly which meant that a component with an empty template would be considered as having a missing template file. Fixes angular#48846. PR Close angular#48849
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.1.2/15.1.3) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.1.2/15.1.3) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.1.2/15.1.3) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.1.2/15.1.3) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.1.2/15.1.3) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.1.2/15.1.3) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.1.2/15.1.3) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.1.2/15.1.3) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v15.1.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1513-2023-02-02) [Compare Source](angular/angular@15.1.2...15.1.3) ##### animations | Commit | Type | Description | | -- | -- | -- | | [d36dfd4b62](angular/angular@d36dfd4) | fix | fix non-animatable warnings for easing ([#​48583](angular/angular#48583)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [a334e4efbe](angular/angular@a334e4e) | fix | warn if using ngSrcset without a configured image loader ([#​48804](angular/angular#48804)) | ##### compiler | Commit | Type | Description | | -- | -- | -- | | [171b4d4640](angular/angular@171b4d4) | fix | incorrect code when non-null assertion is used after a safe access ([#​48801](angular/angular#48801)) | ##### migrations | Commit | Type | Description | | -- | -- | -- | | [9e86dd231b](angular/angular@9e86dd2) | fix | Fixed file format issue with lint ([#​48859](angular/angular#48859)) | | [af31f98b00](angular/angular@af31f98) | fix | migration host incorrectly reading empty files ([#​48849](angular/angular#48849)) | ##### platform-server | Commit | Type | Description | | -- | -- | -- | | [73972c684e](angular/angular@73972c6) | fix | insert transfer state `script` before other `script` tags ([#​48868](angular/angular#48868)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [d5b2c249a3](angular/angular@d5b2c24) | fix | Handle routerLink directive on svg anchors. ([#​48857](angular/angular#48857)) | #### Special Thanks Alan Agius, Besim Gürbüz, Brecht Billiet, Dario Piotrowicz, Dylan Hunn, Iván Navarro, Jessica Janiuk, Kristiyan Kostadinov, Matthieu Riegler, Onkar Ruikar, Payam Valadkhan, Santosh Yadav, Virginia Dooley and Walid Bouguima <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTkuMiIsInVwZGF0ZWRJblZlciI6IjM0LjEyMC4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1769 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes that the migration host was doing a basic falsy check if the content was read correctly which meant that a component with an empty template would be considered as having a missing template file.
Fixes #48846.