fix(platform-server): insert transfer state `script` before other `script` tags #48868

alan-agius4 · 2023-01-27T12:57:33Z

Previously, the state script was always appended as the last item in the body tag. This can result in the state not being available when the Angular application is bootstrap. A workaround for this was to delay the bootstrapping of the application until by using the DOMContentLoaded event listener.

const bootstrap = () => platformBrowserDynamic().bootstrapModule(AppModule);

document.addEventListener('DOMContentLoaded', bootstrap);

With this change the above workaround is no longer necessary as the state script tag is now added prior of any other script which guarantees that the state is present prior of the Angular application is bootstrapped.

…ript` tags Previously, the state `script` was always appended as the last item in the `body` tag. This can result in the state not being available when the Angular application is bootstrap. A workaround for this was to delay the bootstrapping of the application until by using the `DOMContentLoaded` event listener. ```ts const bootstrap = () => platformBrowserDynamic().bootstrapModule(AppModule); document.addEventListener('DOMContentLoaded', bootstrap); ``` With this change the above workaround is no longer necessary as the state `script` tag is now added prior of any other `script` which guarantees that the state is present prior of the Angular application is bootstrapped.

alan-agius4 · 2023-01-27T13:38:36Z

Presubmit: http://test/OCL:505092808:BASE:505092830:1674825905086:59837f83

AndrewKushnir

@alan-agius4 looks great, thanks for the fix 👍

…ript` tags (#48868) Previously, the state `script` was always appended as the last item in the `body` tag. This can result in the state not being available when the Angular application is bootstrap. A workaround for this was to delay the bootstrapping of the application until by using the `DOMContentLoaded` event listener. ```ts const bootstrap = () => platformBrowserDynamic().bootstrapModule(AppModule); document.addEventListener('DOMContentLoaded', bootstrap); ``` With this change the above workaround is no longer necessary as the state `script` tag is now added prior of any other `script` which guarantees that the state is present prior of the Angular application is bootstrapped. PR Close #48868

…ript` tags (angular#48868) Previously, the state `script` was always appended as the last item in the `body` tag. This can result in the state not being available when the Angular application is bootstrap. A workaround for this was to delay the bootstrapping of the application until by using the `DOMContentLoaded` event listener. ```ts const bootstrap = () => platformBrowserDynamic().bootstrapModule(AppModule); document.addEventListener('DOMContentLoaded', bootstrap); ``` With this change the above workaround is no longer necessary as the state `script` tag is now added prior of any other `script` which guarantees that the state is present prior of the Angular application is bootstrapped. PR Close angular#48868

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.1.2/15.1.3) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.1.2/15.1.3) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.1.2/15.1.3) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.1.2/15.1.3) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.1.2/15.1.3) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.1.2/15.1.3) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.1.2/15.1.3) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.1.2/15.1.3) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v15.1.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1513-2023-02-02) [Compare Source](angular/angular@15.1.2...15.1.3) ##### animations | Commit | Type | Description | | -- | -- | -- | | [d36dfd4b62](angular/angular@d36dfd4) | fix | fix non-animatable warnings for easing ([#48583](angular/angular#48583)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [a334e4efbe](angular/angular@a334e4e) | fix | warn if using ngSrcset without a configured image loader ([#48804](angular/angular#48804)) | ##### compiler | Commit | Type | Description | | -- | -- | -- | | [171b4d4640](angular/angular@171b4d4) | fix | incorrect code when non-null assertion is used after a safe access ([#48801](angular/angular#48801)) | ##### migrations | Commit | Type | Description | | -- | -- | -- | | [9e86dd231b](angular/angular@9e86dd2) | fix | Fixed file format issue with lint ([#48859](angular/angular#48859)) | | [af31f98b00](angular/angular@af31f98) | fix | migration host incorrectly reading empty files ([#48849](angular/angular#48849)) | ##### platform-server | Commit | Type | Description | | -- | -- | -- | | [73972c684e](angular/angular@73972c6) | fix | insert transfer state `script` before other `script` tags ([#48868](angular/angular#48868)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [d5b2c249a3](angular/angular@d5b2c24) | fix | Handle routerLink directive on svg anchors. ([#48857](angular/angular#48857)) | #### Special Thanks Alan Agius, Besim Gürbüz, Brecht Billiet, Dario Piotrowicz, Dylan Hunn, Iván Navarro, Jessica Janiuk, Kristiyan Kostadinov, Matthieu Riegler, Onkar Ruikar, Payam Valadkhan, Santosh Yadav, Virginia Dooley and Walid Bouguima  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1769 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

…chematic The bootstrapping wrapping is no longer neccesry as of 15.1.3. See: angular/angular#48868

…schematic The bootstrapping wrapping is no longer necessary as of 15.1.3. See: angular/angular#48868

…schematic The bootstrapping wrapping is no longer necessary as of 15.1.3. See: angular/angular#48868 (cherry picked from commit 88fddc0)

…ther `script` tags (angular#48868)" This reverts commit 2fc5b70 as this change is no longer needed since `type=module` script are deferred by default.

…ther `script` tags (angular#48868)" This reverts commit 2fc5b70 as this change is no longer needed since `type=module` script are deferred by default. Which causes the transfer data to be queried after the browser has finished parsing the DOM.

…ther `script` tags (angular#48868)" This reverts commit 2fc5b70 as this change is no longer needed since `type=module` script are deferred by default.

…ther `script` tags (#48868)" (#49112) This reverts commit 2fc5b70 as this change is no longer needed since `type=module` script are deferred by default. Which causes the transfer data to be queried after the browser has finished parsing the DOM. PR Close #49112

angular-automatic-lock-bot · 2023-03-03T16:06:13Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alan-agius4 added the area: server Issues related to server-side rendering label Jan 27, 2023

ngbot bot added this to the Backlog milestone Jan 27, 2023

alan-agius4 force-pushed the state-script-order branch from 0edf5cd to de67fc1 Compare January 27, 2023 12:58

alan-agius4 added the target: patch This PR is targeted for the next patch release label Jan 27, 2023

alan-agius4 requested a review from AndrewKushnir January 27, 2023 12:58

alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 27, 2023

AndrewKushnir approved these changes Jan 27, 2023

View reviewed changes

AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 27, 2023

alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jan 27, 2023

angular-robot bot closed this in 2fc5b70 Jan 31, 2023

alan-agius4 deleted the state-script-order branch January 31, 2023 07:05

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Feb 6, 2023

fix(@schematics/angular): remove boostrapping wrapping in universal s…

0613ee3

…chematic The bootstrapping wrapping is no longer neccesry as of 15.1.3. See: angular/angular#48868

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Feb 6, 2023

fix(@schematics/angular): remove bootstrapping wrapping in universal …

bb24e61

…schematic The bootstrapping wrapping is no longer necessary as of 15.1.3. See: angular/angular#48868

alan-agius4 mentioned this pull request Feb 6, 2023

fix(@schematics/angular): remove bootstrapping wrapping in universal schematic angular/angular-cli#24666

Merged

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Feb 6, 2023

fix(@schematics/angular): remove bootstrapping wrapping in universal …

d75be42

…schematic The bootstrapping wrapping is no longer necessary as of 15.1.3. See: angular/angular#48868

angular-robot bot pushed a commit to angular/angular-cli that referenced this pull request Feb 7, 2023

fix(@schematics/angular): remove bootstrapping wrapping in universal …

88fddc0

…schematic The bootstrapping wrapping is no longer necessary as of 15.1.3. See: angular/angular#48868

angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(platform-server): insert transfer state `script` before other `script` tags #48868

fix(platform-server): insert transfer state `script` before other `script` tags #48868

alan-agius4 commented Jan 27, 2023

alan-agius4 commented Jan 27, 2023

AndrewKushnir left a comment

angular-automatic-lock-bot bot commented Mar 3, 2023

fix(platform-server): insert transfer state script before other script tags #48868

fix(platform-server): insert transfer state script before other script tags #48868

Conversation

alan-agius4 commented Jan 27, 2023

alan-agius4 commented Jan 27, 2023

AndrewKushnir left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Mar 3, 2023

fix(platform-server): insert transfer state `script` before other `script` tags #48868

fix(platform-server): insert transfer state `script` before other `script` tags #48868