-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(core): change RendererType2.styles
to accept only a flat array
#49072
Conversation
aff8e66
to
28404b9
Compare
28404b9
to
8ff6550
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alan-agius4 looks great, thanks for the cleanup 👍
RendererType2.styles
to accept a only a flat arrayRendererType2.styles
to accept a only a flat array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: fw-core, fw-platform-server, public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
Will wait on #48298 before merging to avoid conflicts for the patch branch. |
While unlikely, prior to this change it was possible to provide a nested array of styles to the render. This required the framework to handle this by doing a flatten operation. This change also renames the `flattenStyles` method as it no longer flattens the styles. BREAKING CHANGE: `RendererType2.styles` no longer accepts a nested arrays. Closes angular#48317
8ff6550
to
c9bd865
Compare
This PR was merged into the repository by commit 9b9c818. |
RendererType2.styles
to accept a only a flat arrayRendererType2.styles
to accept only a flat array
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
While unlikely, prior to this change it was possible to provide a nested array of styles to the render. This required the framework to handle this by doing a flatten operation. This change also renames the
flattenStyles
method as it no longer flattens the styles.BREAKING CHANGE:
RendererType2.styles
no longer accepts a nested arrays.Closes #48317