Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove Angular Compatibility Compiler (ngcc) #49101

Closed
wants to merge 2 commits into from
Closed

feat: remove Angular Compatibility Compiler (ngcc) #49101

wants to merge 2 commits into from

Conversation

alan-agius4
Copy link
Contributor

This commit removes the NGCC code and all the related infra setup required to support it.

BREAKING CHANGE: Angular Compatibility Compiler (ngcc) has been removed and as a result Angular View Engine libraries will no longer work

@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit labels Feb 16, 2023
@alan-agius4 alan-agius4 force-pushed the remove-ngcc branch 2 times, most recently from 18eb2bb to e21d72d Compare February 16, 2023 09:33
@alan-agius4 alan-agius4 added the area: compiler Issues related to `ngc`, Angular's template compiler label Feb 16, 2023
@ngbot ngbot bot added this to the Backlog milestone Feb 16, 2023
@angular-robot angular-robot bot removed the detected: feature PR contains a feature commit label Feb 16, 2023
@alan-agius4 alan-agius4 force-pushed the remove-ngcc branch 3 times, most recently from 4634f36 to 3cbfb17 Compare February 16, 2023 11:42
@alan-agius4
refactor: remove Angular Compatibility Compiler (ngcc)
af98c1b 
This commit removes the NGCC code and all the related infra setup required to support it.

BREAKING CHANGE: Angular Compatibility Compiler (ngcc) has been removed and as a result Angular View Engine libraries will no longer work
@alan-agius4 alan-agius4 marked this pull request as ready for review February 16, 2023 13:47
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 16, 2023
alxhub
alxhub approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ngcc ❤️ but you will not be missed

josephperrott
josephperrott approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

twerske
twerske approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@twerske twerske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on the docs changes

alxhub
alxhub approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global-approval

alxhub
alxhub approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global-approvers

pkozlowski-opensource
pkozlowski-opensource approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 16, 2023
JoostK
JoostK approved these changes Feb 16, 2023
View reviewed changes
packages/compiler-cli/package.json Outdated Show resolved Hide resolved
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Feb 16, 2023
jessicajaniuk
jessicajaniuk approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api, code-ownership

@alxhub
Copy link
Member

alxhub commented Feb 17, 2023

This PR was merged into the repository by commit 48aa96e.

@alxhub alxhub closed this in 48aa96e Feb 17, 2023
@alan-agius4 alan-agius4 deleted the remove-ngcc branch February 17, 2023 06:12
@Yberion Yberion mentioned this pull request Feb 17, 2023
Closed
2 tasks
@stefannikolei stefannikolei mentioned this pull request Feb 28, 2023
Closed
@krishna217 krishna217 mentioned this pull request Mar 9, 2023
Closed
@Abildtoft Abildtoft mentioned this pull request Mar 10, 2023
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

@atscott atscott atscott approved these changes

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@alxhub alxhub alxhub approved these changes

@josephperrott josephperrott josephperrott approved these changes

@twerske twerske twerske approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@alan-agius4 @alxhub @JoostK @atscott @pkozlowski-opensource @josephperrott @twerske @jessicajaniuk