Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): drop support for TypeScript 4.8 #49155

Closed
wants to merge 1 commit into from
Closed

feat(compiler): drop support for TypeScript 4.8 #49155

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 22, 2023 •
edited

Drops support for TypeScript 4.8 from the compiler and removes all of the compatibility code we had for it.

BREAKING CHANGE:

  • TypeScript 4.8 is no longer supported.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: compiler Issues related to `ngc`, Angular's template compiler labels Feb 22, 2023
@ngbot ngbot bot added this to the Backlog milestone Feb 22, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 22, 2023
@crisbeto crisbeto requested a review from JoostK February 22, 2023 08:40
@crisbeto crisbeto marked this pull request as ready for review February 22, 2023 08:40
josephperrott
josephperrott approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JoostK
JoostK approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do we want a "BREAKING CHANGES" note for this one?

@crisbeto
feat(compiler): drop support for TypeScript 4.8
763982a 
Drops support for TypeScript 4.8 from the compiler and removes all of the compatibility code we had for it.

BREAKING CHANGE:
* TypeScript 4.8 is no longer supported.
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Feb 22, 2023
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 22, 2023
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 79cdfeb.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @AndrewKushnir @JoostK @josephperrott