fix(common): invalid ImageKit transformation #49201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tanoabeleyra
force-pushed
the
fix-imagekit-loader
branch
from
43f86df
to
c77ebb3
Compare
|
Hi @khempenius, could you please take a look at this change when you get a chance? Thank you. |
AndrewKushnir
requested review from
AndrewKushnir
and removed request for
atscott
AndrewKushnir
added
action: review
|
@tanoabeleyra thanks for creating this PR! It looks like you need to sign a CLA (see an auto-generated comment above) before we can proceed with the review. Could you please sign the CLA when you get a chance? Thank you. |
|
Hi @AndrewKushnir. I already signed the CLA but it failed on the first try because the email was not my primary one. https://github.com/angular/angular/pull/49201/checks?check_run_id=11590617764 |
|
// cc @atcastle |
AndrewKushnir
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
@tanoabeleyra thanks for improving NgOptimizedImage directive!
q-auto is an invalid/unsupported transformation and should not be used
AndrewKushnir
force-pushed
the
fix-imagekit-loader
branch
from
c77ebb3
to
20feed0
Compare
AndrewKushnir
added
action: presubmit
AndrewKushnir
added
action: merge
AndrewKushnir
approved these changes
Mar 27, 2023
|
This PR was merged into the repository by commit 6499f5a. |
atscott
pushed a commit
that referenced
this pull request
Mar 27, 2023
q-auto is an invalid/unsupported transformation and should not be used PR Close #49201
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 30, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.2.4/15.2.5) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.2.4/15.2.5) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.2.4/15.2.5) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.2.4/15.2.5) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.2.4/15.2.5) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.2.4/15.2.5) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.2.4/15.2.5) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.2.4` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.2.4/15.2.5) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v15.2.5`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1525-2023-03-29) [Compare Source](angular/angular@15.2.4...15.2.5) ##### common | Commit | Type | Description | | -- | -- | -- | | [ca5acadb78](angular/angular@ca5acad) | fix | invalid ImageKit transformation ([#​49201](angular/angular#49201)) | ##### compiler | Commit | Type | Description | | -- | -- | -- | | [077f6b4674](angular/angular@077f6b4) | fix | do not unquote CSS values ([#​49460](angular/angular#49460)) | | [c3cff35869](angular/angular@c3cff35) | fix | handle trailing comma in object literal ([#​49535](angular/angular#49535)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [d201fc2dec](angular/angular@d201fc2) | fix | set style property value to empty string instead of an invalid value ([#​49460](angular/angular#49460)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [978d37f324](angular/angular@978d37f) | fix | Ensure Router preloading works with lazy component and static children ([#​49571](angular/angular#49571)) | | [a844435514](angular/angular@a844435) | fix | fix [#​49457](angular/angular#49457) outlet activating with old info ([#​49459](angular/angular#49459)) | #### Special Thanks Alan Agius, Andrew Scott, Asaf Malin, Jan Cabadaj, Kristiyan Kostadinov, Matthieu Riegler, Paul Gschwendtner, Sid and Tano Abeleyra <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yNC41IiwidXBkYXRlZEluVmVyIjoiMzUuMjQuNSJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1842 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
q-autois an invalid/unsupported transformation and should not be usedPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
ImageLoaderfor ImageKit is using an invalid/unsupported transformation (q-auto).Being that I could not find any mention of this transformation in the official documentation, I contacted ImageKit's support and they said:
Issue Number: N/A
What is the new behavior?
The
q-autoinvalid transformation is not used. Instead, we rely on the default quality value from ImageKit's dashboard, which unless modified is 80 (q-80).Does this PR introduce a breaking change?
Other information
Unless modified (and if not overwritten via URL), ImageKit applies the following transformations:
f-auto)q-80)