-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform-server): bundle @angular/domino in via esbuild #49229
Conversation
036a2c6
to
5ec63eb
Compare
This removes one line that should effectively bundle the angular fork of domino in via esbuild.
5ec63eb
to
c0c2221
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note: We have considered publishing to npm directly, but it would still require changes in all these places + we would need a release setup/process for the fork.
Caretaker: This requires a patch to be merged before landing this PR, which means the G3 test shouldn't matter. I'll run them anyway. |
cc. @josephperrott in case he also wants to have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR was merged into the repository by commit a08a8ff. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This removes one line that should effectively bundle the angular fork of domino in via esbuild.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We're not bundling @angular/domino in with platform-server.
Issue Number: #49228
What is the new behavior?
We are bundling @angular/domino in with platform-server.
Does this PR introduce a breaking change?
Other information