Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform-server): bundle @angular/domino in via esbuild #49229

Closed
wants to merge 1 commit into from

Conversation

jessicajaniuk
Copy link
Contributor

This removes one line that should effectively bundle the angular fork of domino in via esbuild.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

We're not bundling @angular/domino in with platform-server.

Issue Number: #49228

What is the new behavior?

We are bundling @angular/domino in with platform-server.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer area: server Issues related to server-side rendering target: major This PR is targeted for the next major release labels Feb 27, 2023
@ngbot ngbot bot added this to the Backlog milestone Feb 27, 2023
@jessicajaniuk jessicajaniuk force-pushed the domino-bundle branch 5 times, most recently from 036a2c6 to 5ec63eb Compare February 28, 2023 19:15
This removes one line that should effectively bundle the
angular fork of domino in via esbuild.
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: We have considered publishing to npm directly, but it would still require changes in all these places + we would need a release setup/process for the fork.

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 28, 2023
@jessicajaniuk
Copy link
Contributor Author

jessicajaniuk commented Feb 28, 2023

Caretaker: This requires a patch to be merged before landing this PR, which means the G3 test shouldn't matter. I'll run them anyway.

@devversion
Copy link
Member

cc. @josephperrott in case he also wants to have a look.

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit a08a8ff.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 31, 2023
@jessicajaniuk jessicajaniuk deleted the domino-bundle branch April 5, 2023 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants