-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): Expose information about the last successful Navigation
#49235
Conversation
The `Router` already has the `getCurrentNavigation()` helper function to expose information about the ongoing navigation. `lastSuccessfulNavigation` is actually already exposed in the `Navigation` object. This commit only _slightly_ extends the current API surface by providing access to the `lastSuccessfulNavigation` object outside of an ongoing navigation. fixes angular#45685
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: public-api
This PR was merged into the repository by commit ea32c32. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The
Router
already has thegetCurrentNavigation()
helper function to expose information about the ongoing navigation.lastSuccessfulNavigation
is actually already exposed in theNavigation
object. This commit only slightly extends the current API surface by providing access to thelastSuccessfulNavigation
object outside of an ongoing navigation.fixes #45685