-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(server): remove deprecated renderModuleFactory
#49247
Conversation
4ff3a90
to
225c1c2
Compare
The deprecated `renderModuleFactory` has been removed as it is no longer necessary with Ivy. BREAKING CHANGE: `renderModuleFactory` has been removed. Use `renderModule` instead.
225c1c2
to
cf9879a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alan-agius4 thanks for the cleanup 👍
A couple quick comments:
- We can also update an error message here to exclude "[Factory]".
- There is one instance where
renderModuleFactory
is referenced in g3 code which we may need to cleanup before landing this change (just search forrenderModuleFactory
).
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
As discussed on slack, the G3 reference is not a problem as it’s an integration test of a NPM package which is not run in G3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api, fw-platform-server
This PR was merged into the repository by commit 17abe6d. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The deprecated
renderModuleFactory
has been removed as it is no longer necessary with Ivy.BREAKING CHANGE:
renderModuleFactory
has been removed. UserenderModule
instead.//CC @AndrewKushnir